Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proxy-agent to remove vulnerable vm2 dependency #2342

Closed
matthewsac opened this issue Jul 31, 2023 · 8 comments
Closed

Update proxy-agent to remove vulnerable vm2 dependency #2342

matthewsac opened this issue Jul 31, 2023 · 8 comments
Assignees
Labels
c/security Security issue t/bug

Comments

@matthewsac
Copy link

Dependabot issued a critical alert on the vm2 library which is used by proxy-agent. A new version of proxy-agent removes this vulnerability by replacing vm2. Prism needs to be updated to use this new version.

Links to the two Dependabot alerts that relate to this issue:

265
266

Link to the new proxy-agent version to be used:
proxy-agent 406.3.0

NOTE: This update must also be done for spectral and platform-internal. See the links to the other issues in the comments.

@matthewsac
Copy link
Author

matthewsac commented Jul 31, 2023

@EdVinyard
Copy link
Contributor

Hey team! Please add your planning poker estimate with Zenhub @chohmann @brendarearden @daniel-white

@EdVinyard
Copy link
Contributor

Please add your planning poker estimate with Zenhub @matthewmurphy

@daniel-white
Copy link

@stoplightio/tacocats we should consider adopting the same library as spectral: stoplightio/spectral#2513

@EdVinyard
Copy link
Contributor

@daniel-white what are the advantages of hpagent over an upgrade of proxy-agent?

@daniel-white
Copy link

@ed i'm not sure - just wanting to reduce the proliferation of 3rd party dependencies.

@EdVinyard
Copy link
Contributor

@P0lip , could you help us understand why you chose to switch to hpagent instead of upgrading proxy-agent in stoplightio/spectral#2513? Do you think we should switch to that in prism, too?

@P0lip
Copy link
Contributor

P0lip commented Aug 1, 2023

It was recommended in stoplightio/spectral#2510 (comment)
hpagent is a 0-dependency module, so that was mostly the reasoning.
In the case of Spectral, proxy-agent has been a bit of a pain for me in terms of vulnerabilities due to its reliance on a number of dependencies that tended to be vulnerable.

Do you think we should switch to that in prism, too?

I'd consider it if it's easy to set up. In the case of Spectral, I didn't need to change much code so I went for the change hoping it'll reduce the number of vulnerability reports caused by transient dependencies of proxy-agent.

@chohmann chohmann self-assigned this Aug 2, 2023
@chohmann chohmann closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/security Security issue t/bug
Projects
None yet
Development

No branches or pull requests

5 participants