Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce costs on kinesis streams #231

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

vasco-santos
Copy link
Contributor

@vasco-santos vasco-santos commented Sep 18, 2023

We are currently being billed quite a bit in AWS for all the Kinesis streams we keep open for dev/CI.

This PR addresses this by:

  • not deploying 2 kinesis streams per env to keep historical content. We really just need the production stream still deployed until we read it.
  • we can also decrease the persistence of the streams to keep costs down

As follow ups, we should also consider (I will create issues):

  • tool that proactively tears down running infrastructure for stalled PRs (or setup tests in a way that kinesis is put on and off for the tests)
  • get historical content kinesis stream flushed out

export function getKinesisStreamConfig (stack) {
if (stack.stage !== 'production') {
return {
retentionPeriod: Duration.hours(24)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimum value supported

@seed-deploy seed-deploy bot temporarily deployed to pr231 September 18, 2023 10:39 Inactive
@seed-deploy
Copy link

seed-deploy bot commented Sep 18, 2023

View stack outputs

Copy link
Member

@travis travis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thanks @vasco-santos!

@vasco-santos vasco-santos merged commit 7803885 into main Sep 19, 2023
1 check passed
@vasco-santos vasco-santos deleted the fix/reduce-costs-on-kinesis-deployments branch September 19, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants