Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package.json explicitly wants w3up-client@11.2.1 #606

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Dec 8, 2023

@gobengo gobengo changed the title fix: package.json explicitly wants w3up-client for 11.2.1 fix: package.json explicitly wants w3up-client@11.2.1 Dec 8, 2023
@gobengo gobengo marked this pull request as ready for review December 8, 2023 22:48
@gobengo gobengo requested a review from travis December 8, 2023 22:48
@@ -1,4 +1,4 @@
lockfileVersion: '6.0'
lockfileVersion: '6.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you using the latest pnpm? I think there was a weird bug in a version of pnpm that did this, and was reverted. they may have un-reverted it though so if you're on the latest pnpm I'm sure you're good! I'll check too...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@travis I'm on pnpm 8.6.1 (i just got latest) and I did a re- pnpm install and did not produce different lockfile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(i upgraded to 8.12.0 and it produces identical lockfile)

@gobengo gobengo merged commit ffa8d1a into main Dec 8, 2023
3 checks passed
@gobengo gobengo deleted the w3up-client-11-2-1 branch December 8, 2023 23:17
travis pushed a commit that referenced this pull request Dec 8, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.1.1](core-v1.1.0...core-v1.1.1)
(2023-12-08)


### Bug Fixes

* package.json explicitly wants w3up-client@11.2.1
([#606](#606))
([ffa8d1a](ffa8d1a))
* upgrade access client to incorporate fixed indexeddb store
([#604](#604))
([2eb8a20](2eb8a20))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants