Stratis support v2 #952
Merged
Stratis support v2 #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechtrefny
force-pushed
the
3.5-devel_stratis-support-v2
branch
4 times, most recently
from
5cf7ec4
to
89d6c7b
Compare
dwlehman
approved these changes
Jul 12, 2021
| space += sum(p.size for p in self.pool.parents) | ||
| log.debug("size bumped to %s to include Stratis pool parents", space) | ||
|
|
||
| space += self._get_free_disk_space() |
There was a problem hiding this comment.
Maybe you could move this down as the implementation of _get_device_space? It's a strange case for sure. One way or another it would be good to remove the FIXME from _get_device_space, even if the implementation stays as it is now.
There was a problem hiding this comment.
Good catch. The FIXME from _get_device_space actually refers to missing support for checking used space in pools, I was waiting for a new stratis API for this and forgot to implement free space and metadata usage in pools and filesystems. This needs to be added to both devicefactory and devices/stratis.
vojtechtrefny
force-pushed
the
3.5-devel_stratis-support-v2
branch
from
89d6c7b
to
2141619
Compare
Currently only Stratis private devices are being ignored.
New StratisBlockdev format and two new devices StratisPoolDevice and StratisFilesystemDevice has been added. Stratis devices are populated using data from Stratis DBus API (cached in static_data.stratis_info).
We are ignoring a lot of stratis private device mapper devices now so we can no longer use libblockdev DM plugin to remove Stratis storage stack and we need to use Stratis DBus API instead.
devicelibs.stratis uses stratis_info so we can't import constants from it here without breaking Python.
This will allow us handling the XFS filesystem on Stratis in a better way to avoid creating and removing it separately (it should be created and removed automatically together with the Stratis filesystem block device).
Locked pools are tricky because Stratis uses LUKS but the "Stratis LUKS devices" can't be unlocked with cryptsetup, only with Stratis API. This implementation "hides" the LUKS device for locked pools and use the StratisBlockdev format for them instead. To unlock a locked pool, unlock_pool() function of the StratisBlockdev format must be used.
The internal private dm-crypt device is created and destroyed together with the pool so having it in the tree would make things even more complicated.
vojtechtrefny
force-pushed
the
3.5-devel_stratis-support-v2
branch
from
2141619
to
f3bbdd7
Compare
When creating a new filesystem we need to check whether the pool has enough free space for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of #915 I made some smaller changes in the code, the biggest difference are names of the Stratis devices, I've removed the underscore in
stratis poolandstratis filesystemto make it more consistent with our other names. This now includes support for both "normal" and encrypted pools.I've also moved this to 3.5-devel to make 3.4.0 release a little bit smaller and to have more time for testing and review here.
You can use blivet-gui for testing (everything except devicefactory support), I have a PR with experimental Stratis support here storaged-project/blivet-gui#277