fix: Return :commit since :ack does not commit in v2
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abel-stord
changed the title
abel-stord
changed the title
:commit since :ack does not commit in v2
abel-stord
force-pushed
the
abel/fix-message-handler
branch
from
5f84305
to
a6112ba
Compare
btkostner
pushed a commit
that referenced
this pull request
Mar 8, 2024
An automated release has been created for you. --- ## [3.0.3](v3.0.2...v3.0.3) (2024-03-08) ### Bug Fixes * Return `:commit` since `:ack` does not commit in v2 ([#84](#84)) ([15bd941](15bd941)) ### Miscellaneous * PR template and checklist ([#82](#82)) ([ed71ff8](ed71ff8)) * Sync files with stordco/common-config-elixir ([#76](#76)) ([b23560e](b23560e)) * Sync files with stordco/common-config-elixir ([#81](#81)) ([58aba7b](58aba7b)) * Update readme info about producer testing ([#73](#73)) ([00b633a](00b633a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Problem
When using the
brod_group_subscriber_v2ourhandle_message/3callback was returning{:ok, :ack, state}. This was the old way to commit messages; in v2, it only acks and doesn't commit based on this comment:https://github.com/kafka4beam/brod/blob/master/src/brod_group_subscriber_worker.erl#L85
Details
Changed to commit