re-evaluate use of Minio health check / metrics

[wthorp]

We seem to have RegisterHealthCheckRouter and RegisterMetricsRouter imported from Minio. Do we use these? Should we?

[halkyon]

Not sure what the intent of keeping minio health and metrics routes was for, but the routes do appear to work still: https://gateway.us1.storjshare.io/minio/health/live (returns HTTP 200). Metrics routes under minio/v2/metrics are blocked as the auth has been disabled but can be seen if environment var MINIO_PROMETHEUS_AUTH_TYPE=public is defined before running gateway-mt.

Perhaps these routes were set up in 86fb710 as part of getting CI tests to work, but I can't recall.

See https://gist.github.com/halkyon/f0a32aad663733380b986601ee53bf97 for a sample of the metrics that minio emits. The code for the collector can be found here: https://github.com/storj/minio/blob/main/cmd/metrics-v2.go

I'm not sure if minio metrics provide anything we'd find useful outside of our own middleware, with additions like https://review.dev.storj.io/c/storj/gateway-mt/+/6949.

@amwolff FYI :)

[amwolff]

I wonder if it's easier to create a subsystem to push these metrics to monkit or rely on what we have/will have in gateway-mt's code. I'm slightly inclined towards the latter.

[storjBuildBot]

Change https://review.dev.storj.io/c/storj/gateway-mt/+/6964 mentions this issue.