Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release versioning #58

Closed
wthorp opened this issue Oct 12, 2021 · 2 comments
Closed

Fix release versioning #58

wthorp opened this issue Oct 12, 2021 · 2 comments
Assignees
@halkyon

Comments

@wthorp
Copy link
Contributor

wthorp commented Oct 12, 2021

The edge services can't report their version number correctly, because the versioning build process doesn't quite work right for them. We end up having to manually set flags which say its a release build, etc. Also, since we create that process, Go now supports release tagging as a feature, without our custom process. Find what make sense for Edge and update things so our releases are properly tagged.
@halkyon halkyon mentioned this issue Oct 31, 2021
Closed
@halkyon halkyon self-assigned this Nov 1, 2021
@halkyon
Copy link
Contributor

halkyon commented Nov 1, 2021 •
edited
Loading

The immediate issue with storj-release not setting the ldflags is fixed here: https://review.dev.storj.io/c/storj/ci/+/6193

@amwolff
Copy link
Member

amwolff commented Dec 21, 2021

Closed by storj/ci@67bd761.

@amwolff amwolff closed this as completed Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@halkyon halkyon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@halkyon @wthorp @amwolff