Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage Node Dashboard shortcut opens the SNOboard #3171

Merged
merged 3 commits into from
Oct 8, 2019
Merged

Storage Node Dashboard shortcut opens the SNOboard #3171

merged 3 commits into from
Oct 8, 2019

Conversation

kaloyan-raev
Copy link
Member

@kaloyan-raev kaloyan-raev commented Oct 3, 2019 •
edited

What: Modifies the "Storage Node Dashboard" to open the SNOboard instead of the CLI dashboard.

Why: With #3164, the SNOboard will be embedded in the storage node binary and thus installed by the Windows Installer. We prefer SNOs to use the new SNOboard instead of the old CLI dashboard. See https://storjlabs.atlassian.net/browse/V3-2721

Please describe the tests: N/A

Please describe the performance impact: None

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@kaloyan-raev kaloyan-raev requested a review from a team October 3, 2019 14:39
@cla-bot cla-bot bot added the cla-signed label Oct 3, 2019
@ghost ghost requested review from coyle and wthorp and removed request for a team October 3, 2019 14:40
@kaloyan-raev kaloyan-raev added the Request Code Review Code review requested label Oct 3, 2019
wthorp
wthorp approved these changes Oct 7, 2019
View reviewed changes
installer/windows/Product.wxs
<!-- We use a standard shortcut to 'cmd.exe /C "start http://localhost:14002"' instead of util:InternetShortcut,
so it appears as an App Shortcut with icon in the Windows Start Menu. In contrast, InternetShortcut does
not support icons in the Start Menu. -->
<Shortcut Id="DashboardShortcut" Name="Storage Node Dashboard" Description="Open the dashboard for the storage node" Directory="StorageNodeStartMenuFolder" Target="[System64Folder]cmd.exe" Arguments="/C &quot;start http://localhost:14002&quot;">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this port could be changed via config; it might be nice to have storagenode.exe kick off 'start' and guarantee the right port

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installer does not advertise this configuration in the wizard. When the installation completes, this shortcut works properly. The SNO can change the port later in the config.yaml, but the same way they can edit the shortcut too.

@kaloyan-raev kaloyan-raev merged commit 828b0af into master Oct 8, 2019
@kaloyan-raev kaloyan-raev deleted the orange/installer-snoboard-shortcut branch October 8, 2019 07:23
bryanchriswhite added a commit that referenced this pull request Oct 9, 2019
@bryanchriswhite
Merge remote-tracking branch 'storj/master' into team-literally-anyth…
fa4547a 
…ing/track-monkit-func-names-used

* storj/master: (62 commits)
  Fix typo in libuplink docs. (#3222)
  satellite/audit: fix audit panic (#3217)
  installer/windows: checkbox for opening SNOboard after installation (#3212)
  satellite/console: Removed 'user not found' message on password reset request (#3184)
  satellite/audit: add mutex to pieceHashesVerified map (#3214)
  satellite/overlay: do not include gracefully exiting nodes in node selection (#3211)
  cmd/storagenode: enable migration of configs of different types (#3189)
  satellite/gracefulexit: Add protobuf definitions for communication between storage node and satellite (#3201)
  satellite/metainfo: remove Iterate from service (#3196)
  satellite/overlay: remove overlay.IsVetted (#3203)
  Fix jenkins builds of storagenode console. (#3208)
  installer/windows: add to private Jenkins build (#3206)
  storagenode/signature: Reject uploads with a timestamp too far in the future (#3194)
  satellite/audit: Add piece hash verified to log messages (#3204)
  storagenode: embed the console into the binary and makefile (#3164)
  Update links to documentation (#3198)
  Storage Node Dashboard shortcut opens the SNOboard (#3171)
  satellite/accounting: implement tally as an observer (#2992)
  satellite/gracefulexit: add transfer queue for pieces (#3174)
  satellite/audit: do not fail or contain nodes for audited segments that are not piece-hash-verified (#3161)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wthorp wthorp wthorp approved these changes

@mniewrzal mniewrzal mniewrzal approved these changes

@coyle coyle Awaiting requested review from coyle

Assignees
No one assigned
Labels
cla-signed Request Code Review Code review requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kaloyan-raev @wthorp @mniewrzal