storagenode/signature: Reject uploads with a timestamp too far in the future #3194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
bryanchriswhite and
zeebo
and removed request for
a team
littleskunk
added
Request Code Review
bryanchriswhite
approved these changes
Oct 7, 2019
There was a problem hiding this comment.
This seems pretty straightforward, I just have a question about the expected behavior.
Are we sure that we want to use the same value for past and future grace period durations? Is it expected by the user that this config value would represent half of the total window of valid times and/or should we halve our defaults for this value?
|
The user doesn't know the config on the satellite side. At the moment both configs are in sync and if we want to change the timewindow we would have to do it on both sides. If the clock has an offset of 50 minutes the upload will still be accepted as long as the upload takes less than 10 minutes. |
ifraixedes
approved these changes
Oct 8, 2019
bryanchriswhite
added a commit
that referenced
this pull request
Oct 9, 2019
…ing/track-monkit-func-names-used * storj/master: (62 commits) Fix typo in libuplink docs. (#3222) satellite/audit: fix audit panic (#3217) installer/windows: checkbox for opening SNOboard after installation (#3212) satellite/console: Removed 'user not found' message on password reset request (#3184) satellite/audit: add mutex to pieceHashesVerified map (#3214) satellite/overlay: do not include gracefully exiting nodes in node selection (#3211) cmd/storagenode: enable migration of configs of different types (#3189) satellite/gracefulexit: Add protobuf definitions for communication between storage node and satellite (#3201) satellite/metainfo: remove Iterate from service (#3196) satellite/overlay: remove overlay.IsVetted (#3203) Fix jenkins builds of storagenode console. (#3208) installer/windows: add to private Jenkins build (#3206) storagenode/signature: Reject uploads with a timestamp too far in the future (#3194) satellite/audit: Add piece hash verified to log messages (#3204) storagenode: embed the console into the binary and makefile (#3164) Update links to documentation (#3198) Storage Node Dashboard shortcut opens the SNOboard (#3171) satellite/accounting: implement tally as an observer (#2992) satellite/gracefulexit: add transfer queue for pieces (#3174) satellite/audit: do not fail or contain nodes for audited segments that are not piece-hash-verified (#3161) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Reject uploads if the OrderCreation timestamp is too far in the future.
Why: Most likely the storage node clock is out of sync. In that case the satellite will remove the pointer because the storage node signature is too old. We are upload pieces to the storage node and later call garbage collection to delete all the data. This PR will reject the upload in the first place. We don't want to waste traffic. Hopefully the storage node will notice the error messages in the logfile and fix the system clock.
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)