Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installer/windows: checkbox for opening SNOboard after installation #3212

Merged
merged 11 commits into from
Oct 9, 2019
Merged

installer/windows: checkbox for opening SNOboard after installation #3212

merged 11 commits into from
Oct 9, 2019

Conversation

Fadila82
Copy link
Contributor

@Fadila82 Fadila82 commented Oct 8, 2019 •
edited by kaloyan-raev

What: checkbox for opening the SNOboard when the Finish button is clicked.
Acceptance criteria:

  • The ExitDialog display a checkbox offering to open the SNOboard
  • The checkbox is check by default, but can be unchecked by the user
  • If the checkbox is checked, the SNOboard (http://localhost:14002/) will open in the default browser when the user clicks the Finish button

Why: So the user can directly access their dashboard after installation

Please describe the tests: no test

Please describe the performance impact: none

Code Review Checklist (to be filled out by reviewer)

  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@Fadila82 Fadila82 requested a review from a team October 8, 2019 16:15
@cla-bot cla-bot bot added the cla-signed label Oct 8, 2019
@ghost ghost requested review from ethanadams and thepaul and removed request for a team October 8, 2019 16:15
@Fadila82 Fadila82 added the WIP Work In Progress label Oct 8, 2019
@Fadila82 Fadila82 added Request Code Review Code review requested and removed WIP Work In Progress labels Oct 8, 2019
@kaloyan-raev kaloyan-raev changed the title Windows installer: checkbox for opening SNOdashboard after installation installer/windows: checkbox for opening SNOboard after installation Oct 9, 2019
mniewrzal
mniewrzal reviewed Oct 9, 2019
View reviewed changes
installer/windows/Product.wxs
@@ -83,19 +83,26 @@
<Property Id="STORJ_STORAGEDIR">STORAGEDIR</Property>
<Property Id="STORJ_STORAGE">1.0</Property>
<Property Id="STORJ_BANDWIDTH">2.0</Property>
<Property Id="WIXUI_EXITDIALOGOPTIONALCHECKBOXTEXT" Value="Launch SNOBoard" />
<Property Id="WIXUI_EXITDIALOGOPTIONALCHECKBOX" Value="1"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use more meaningful name for that? e.g. WIXUI_EXITDIALOGOPENDASHBOARDCHECKBOX

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a built-in property in the standard ExitDialog of WiX Toolset :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, then looks good ;)

@Fadila82 Fadila82 merged commit 2e4d863 into master Oct 9, 2019
@Fadila82 Fadila82 deleted the orange/win-installer-open-dashboard branch October 9, 2019 13:13
bryanchriswhite added a commit that referenced this pull request Oct 9, 2019
@bryanchriswhite
Merge remote-tracking branch 'storj/master' into team-literally-anyth…
fa4547a 
…ing/track-monkit-func-names-used

* storj/master: (62 commits)
  Fix typo in libuplink docs. (#3222)
  satellite/audit: fix audit panic (#3217)
  installer/windows: checkbox for opening SNOboard after installation (#3212)
  satellite/console: Removed 'user not found' message on password reset request (#3184)
  satellite/audit: add mutex to pieceHashesVerified map (#3214)
  satellite/overlay: do not include gracefully exiting nodes in node selection (#3211)
  cmd/storagenode: enable migration of configs of different types (#3189)
  satellite/gracefulexit: Add protobuf definitions for communication between storage node and satellite (#3201)
  satellite/metainfo: remove Iterate from service (#3196)
  satellite/overlay: remove overlay.IsVetted (#3203)
  Fix jenkins builds of storagenode console. (#3208)
  installer/windows: add to private Jenkins build (#3206)
  storagenode/signature: Reject uploads with a timestamp too far in the future (#3194)
  satellite/audit: Add piece hash verified to log messages (#3204)
  storagenode: embed the console into the binary and makefile (#3164)
  Update links to documentation (#3198)
  Storage Node Dashboard shortcut opens the SNOboard (#3171)
  satellite/accounting: implement tally as an observer (#2992)
  satellite/gracefulexit: add transfer queue for pieces (#3174)
  satellite/audit: do not fail or contain nodes for audited segments that are not piece-hash-verified (#3161)
  ...
isaachess pushed a commit that referenced this pull request Oct 10, 2019
@Fadila82 @isaachess
installer/windows: checkbox for opening SNOboard after installation (#…
502837c 
…3212)
littleskunk pushed a commit that referenced this pull request Oct 16, 2019
@Fadila82 @littleskunk
installer/windows: checkbox for opening SNOboard after installation (#…
293a5bb 
…3212)

(cherry picked from commit 2e4d863)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaloyan-raev kaloyan-raev kaloyan-raev approved these changes

@mniewrzal mniewrzal mniewrzal approved these changes

@ethanadams ethanadams Awaiting requested review from ethanadams

@thepaul thepaul Awaiting requested review from thepaul

Assignees
No one assigned
Labels
cla-signed Request Code Review Code review requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fadila82 @kaloyan-raev @mniewrzal