Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Fix auto expansion of custom data #110

Closed
wants to merge 2 commits into from
Closed

Fix auto expansion of custom data #110

wants to merge 2 commits into from

Conversation

erbridge
Copy link
Contributor

No description provided.

@rdegges
Copy link
Contributor

rdegges commented Sep 30, 2015

I pushed this fix in manually, as we did some big refactoring which would have broken the merge! Thanks! Will cut a release tomorrow.

@rdegges rdegges closed this Sep 30, 2015
@bassie1995
Copy link

This hasn't fixed the issue for me, it still gives me the Object with only an href in it.

@rdegges
Copy link
Contributor

rdegges commented Oct 1, 2015

This release hasn't been cut yet, sorry! Adding in testing around it.

@bassie1995
Copy link

Is this in 2.0.9? It still doesn't seem to work for me.

@robertjd
Copy link
Member

robertjd commented Oct 8, 2015

This should be fixed in 2.0.9, can you give me more context for your problem? If you could share your code with me that would be really helpful. If you don't want to share here you can contact us privately via support@stormpath.com

@bassie1995
Copy link

Yep, my app.js is as follows:
https://gist.github.com/bassie1995/9feafbc4fb72166c00f8.

Tried to use just expandCustomData: true as well.

I'll be glad to provide more info.

@erbridge erbridge deleted the fix-expand-custom-data branch October 8, 2015 23:25
@erbridge
Copy link
Contributor Author

erbridge commented Oct 8, 2015

This is working for me now. I think you need:

expand: {
  customData: true
}

not expandCustomData: true.

Also, you probably want to reset your API keys since they're completely exposed in that gist...

@bassie1995
Copy link

Huh, that did fix it. I have tried that (or something close, I guess) before, but I'm glad it works now.

I'll be resetting the keys once we go live, as well :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants