Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubuntu on WSL2 (Windows) causing "export" errors with unquoted Windows style paths #1296

Closed
wwlwpd opened this issue Apr 17, 2024 · 0 comments · Fixed by #1297
Closed

Ubuntu on WSL2 (Windows) causing "export" errors with unquoted Windows style paths #1296

wwlwpd opened this issue Apr 17, 2024 · 0 comments · Fixed by #1297
Assignees
@wwlwpd
Labels
portability issues related to running in as many environments as possible Windows/WSL related to functionality on Windows

Comments

@wwlwpd
Copy link
Collaborator

wwlwpd commented Apr 17, 2024

  1. happens when ./asgsh is being written (PATH)
  2. happens during save profile (ASGS_BREW_FLAGS)
wwlwpd added a commit that referenced this issue Apr 17, 2024
@wwlwpd
Added quotes around exported variables in profile for Windows paths.
c7460af 
Issue 1296: Windows paths were causing start up issues, and it was discovered
that the environmental variables were not being quoted. Additionally, it was
discovered and fixed that the variable, "ASGS_BREW_FLAGS", was being quoted too
early in the process. This was adjusted to be treated like the others.

In addition to this, the default "$WORK" and "$SCRATCH" directories for "debian"
were adjusted so that they wer under $HOME, and not a root level directory that
would show unnecessary warnings for non-privileged users.

Resolves #1296.
@wwlwpd wwlwpd mentioned this issue Apr 17, 2024
Merged
@wwlwpd wwlwpd self-assigned this Apr 17, 2024
@wwlwpd wwlwpd added Windows/WSL related to functionality on Windows portability issues related to running in as many environments as possible labels Apr 17, 2024
wwlwpd added a commit that referenced this issue Apr 22, 2024
@wwlwpd
Added quotes around exported variables in profile for Windows paths.
cab2cbe 
Issue 1296: Windows paths were causing start up issues, and it was discovered
that the environmental variables were not being quoted. Additionally, it was
discovered and fixed that the variable, "ASGS_BREW_FLAGS", was being quoted too
early in the process. This was adjusted to be treated like the others.

In addition to this, the default "$WORK" and "$SCRATCH" directories for "debian"
were adjusted so that they wer under $HOME, and not a root level directory that
would show unnecessary warnings for non-privileged users.

Resolves #1296.
Resolves #1297 (PR).
wwlwpd added a commit that referenced this issue May 5, 2024
@wwlwpd
Added quotes around exported variables in profile for Windows paths.
e04642b 
Issue 1296: Windows paths were causing start up issues, and it was discovered
that the environmental variables were not being quoted. Additionally, it was
discovered and fixed that the variable, "ASGS_BREW_FLAGS", was being quoted too
early in the process. This was adjusted to be treated like the others.

In addition to this, the default "$WORK" and "$SCRATCH" directories for "debian"
were adjusted so that they wer under $HOME, and not a root level directory that
would show unnecessary warnings for non-privileged users.

Resolves #1296.
Resolves #1297 (PR).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wwlwpd wwlwpd

Labels
portability issues related to running in as many environments as possible Windows/WSL related to functionality on Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added quotes around exported variables in profile for Windows paths. StormSurgeLive/asgs
1 participant
@wwlwpd