Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Exports config break vite based build #58

Open
morewings opened this issue Oct 20, 2023 · 0 comments
Open

[Bug] Exports config break vite based build #58

morewings opened this issue Oct 20, 2023 · 0 comments
Assignees
@ShaunEvening
Labels
bug Something isn't working

Comments

@morewings
Copy link
Contributor

morewings commented Oct 20, 2023 •
edited
Loading

Describe the bug

When user runs Storybook on vite ESM exports config (.mjs) makes it are not capable to build.

Steps to reproduce the behavior

  1. Set up vite based storybook
  2. Install storybook-addon-theme-provider@0.1.10
  3. Run build-storybook
  4. Error happens.

Expected behavior

Should work

Screenshots and/or logs

Available here morewings/storybook-addon-theme-provider#11

Additional context

I managed to fix it by removing exports config from package.json and using only cjs build. Not sure if it's the best way.
@morewings morewings added the bug Something isn't working label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShaunEvening ShaunEvening

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@morewings @ShaunEvening