Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions of peer dependencies to allow latest Vite and Vite Svelte plugin #159

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

joekrump
Copy link
Contributor

@joekrump joekrump commented Nov 23, 2023

Fixes #161

Now that Vite 5 has been released, it would be nice to have te versions of the peer dependencies for it and the Svelte Vite plugin which uses Vite, updated to the latest versions. If this could be published as a new release that would most awesome!

…elte plugin

Now that [Vite 5 has been released](https://vitejs.dev/blog/announcing-vite5), it would be nice to have te versions of the peer dependencies for it and the Svelte Vite plugin which uses Vite, updated to the latest versions. If this could be published as a new release that would most awesome!
@joekrump joekrump changed the title Update versions of peer dependencies to allow latest Vite and Vite Sv… Update versions of peer dependencies to allow latest Vite and Vite Svelte plugin Nov 23, 2023
@j3rem1e
Copy link
Contributor

j3rem1e commented Nov 30, 2023

I don't think it's a good idea to drop support for vite4 now

@joekrump
Copy link
Contributor Author

I don't think it's a good idea to drop support for vite4 now

@j3rem1e are you able to say a little more about the thinking behind that?

I agree that vite 4 should still be supported since it is widely used. To do this and support vite 5, a new major release of this package could be made that supports vite >=5 while still doing minor release bumps for the current major version that requires vite <= 4. Curious to hear your thoughts on that path forward.

package.json Outdated Show resolved Hide resolved
Co-authored-by: Andrey Sitnik <andrey@sitnik.ru>
@matths
Copy link

matths commented Dec 13, 2023

Any news here? It's two weeks and I would appreciate this addon working with Vite5.

Copy link
Collaborator

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we can do this without a breaking change, supporting both versions?
Otherwise I'd expect some logic changes as well somewhere.

I would advice against dropping support for Vite 4 given that SvelteKit still uses it.

package.json Outdated Show resolved Hide resolved
Co-authored-by: Jeppe Reinhold <jeppe@reinhold.is>
@JReinhold
Copy link
Collaborator

If someone is willing to test this addon in a Vite 5 project and can confirm it works fine, I'd be happy to merge and release this.

@JReinhold JReinhold added minor Increment the minor version when merged dependencies Update one or more dependencies version labels Dec 20, 2023
@matths
Copy link

matths commented Dec 21, 2023

If someone is willing to test this addon in a Vite 5 project and can confirm it works fine, I'd be happy to merge and release this.

@JReinhold We would need a package to include to test it with our Svelte project. Any advice how to come up with that?

@Masstronaut
Copy link

@matths could you use the existing release and update the package.json as is done in this PR? It's a 2 line change.

@Masstronaut
Copy link

I tested this in a new sveltekit project per the sveltekit docs:

npm create svelte@latest my-app
cd my-app
npm install

and in my package.json "devDependencies" have:

"@sveltejs/kit": "^2.0.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"vite": "^5.0.3",
"svelte": "^4.2.7",
...

I then ran npx storybook init and npm i -D @storybook/addon-svelte-csf --force and can confirm that storybook seemed to be working fine with no issues. Will report back when I have a chance to test it on a larger project.

@JReinhold JReinhold merged commit 5915820 into storybookjs:main Dec 29, 2023
2 checks passed
@shilman
Copy link
Member

shilman commented Dec 29, 2023

🚀 PR was released in v4.1.0 🚀

@shilman shilman added the released This issue/pull request has been released. label Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support for vite 5.x
7 participants