Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use overrides from SB rather than defining ourselves #254

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Use overrides from SB rather than defining ourselves #254

merged 1 commit into from
Jun 1, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented May 27, 2022 •
edited by shilman
Loading

Fixes storybookjs/storybook#18322

SB Core uses overrides to fix sort order for webpack5 but this is getting thrown away by the CRA preset

@tmeasday tmeasday requested review from shilman and mrmckeb May 27, 2022 03:24
@shilman shilman added bug Something isn't working create-react-app labels May 27, 2022
shilman
shilman approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. DRY & easier to maintain!

@mrmckeb any concerns about this?

@shilman shilman merged commit acbe13d into master Jun 1, 2022
@shilman shilman deleted the 18322-pass-overrides branch June 1, 2022 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

Assignees
No one assigned
Labels
bug Something isn't working create-react-app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stories are not sorted in export order in CRA
2 participants
@tmeasday @shilman