Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type annotation for storiesOf method #124

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

jkepps
Copy link
Contributor

@jkepps jkepps commented Oct 27, 2020

Issue: #123

What I did

Fixed the type annotation for the storiesOf method.

How to test

Convert Button.stories.js to a typescript file and verify there are no type errors.

  • Is this testable with Jest or Chromatic screenshots?
    • no
  • Does this need a new example in the kitchen sink apps?
    • Probably wouldn't hurt to have a typescript example, but i think that's beyond the scope of this PR
  • Does this need an update to the documentation?
    • There could absolutely be more information in the docs about how to use typescript with this library, but again, i think that's beyond the scope of this PR

If your answer is yes to any of these, please make sure to include it in your PR.

@jkepps
Copy link
Contributor Author

jkepps commented Oct 27, 2020

Btw, there is no next branch. Should the PR template be updated? or did the next branch get deleted by accident?

@dannyhw
Copy link
Member

dannyhw commented Nov 2, 2020

@jkepps that needs to be updated. At this point master is being used. Will check this PR tonight, seems good though.

@dannyhw dannyhw merged commit 1d86450 into storybookjs:master Nov 3, 2020
@dannyhw
Copy link
Member

dannyhw commented Nov 3, 2020

@jkepps thanks for your contribution :)

@jkepps jkepps deleted the stories-of-type branch November 4, 2020 19:30
@dannyhw
Copy link
Member

dannyhw commented Nov 22, 2020

Published:

  • @storybook/addon-ondevice-knobs@5.3.24-alpha.0
  • @storybook/react-native@5.3.24-alpha.0

Bug Fixes

Your change is live now in 5.3.24-alpha.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants