Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset groupId when a story is selected #137

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Reset groupId when a story is selected #137

merged 1 commit into from
Nov 19, 2020

Conversation

sangonz193
Copy link
Contributor

Issue: #126

What I did

Reset the state groupId to the default one when a story gets selected.

@dannyhw dannyhw added bug Something isn't working addon: knobs labels Nov 19, 2020
@dannyhw dannyhw merged commit b176f73 into storybookjs:master Nov 19, 2020
@dannyhw
Copy link
Member

dannyhw commented Nov 19, 2020

Thanks for your contribution! seems all good. I'll let you know when there is a alpha out with your changes.

@sangonz193
Copy link
Contributor Author

Thank you!

@sangonz193 sangonz193 deleted the fix/groups-not-rendering-group-id branch November 20, 2020 09:42
@dannyhw
Copy link
Member

dannyhw commented Nov 22, 2020

Published:

  • @storybook/addon-ondevice-knobs@5.3.24-alpha.0
  • @storybook/react-native@5.3.24-alpha.0

Bug Fixes

Your change is live now in 5.3.24-alpha.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: knobs bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants