Skip to content

Commit

Permalink
Merge pull request #16137 from storybookjs/angular/clean-unused-code
Browse files Browse the repository at this point in the history
Angular: Remove dead code in client
  • Loading branch information
shilman committed Sep 25, 2021
2 parents cf2c75b + 432c93f commit 0a7143c
Show file tree
Hide file tree
Showing 8 changed files with 25 additions and 495 deletions.
1 change: 0 additions & 1 deletion app/angular/element-renderer.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion app/angular/element-renderer.js

This file was deleted.

This file was deleted.

Expand Up @@ -73,6 +73,31 @@ describe('RendererFactory', () => {
);
});

it('should handle circular reference in moduleMetadata', async () => {
class Thing {
token: Thing;

constructor() {
this.token = this;
}
}
const token = new Thing();

const render = await rendererFactory.getRendererInstance('my-story', rootTargetDOMNode);
await render.render({
storyFnAngular: {
template: '🦊',
props: {},
moduleMetadata: { providers: [{ provide: 'foo', useValue: token }] },
},
forced: false,
parameters: {},
targetDOMNode: rootTargetDOMNode,
});

expect(document.body.getElementsByTagName('my-story')[0].innerHTML).toBe('🦊');
});

describe('when forced=true', () => {
beforeEach(async () => {
// Init first render
Expand Down
241 changes: 0 additions & 241 deletions app/angular/src/client/preview/angular-beta/RendererService.test.ts

This file was deleted.

0 comments on commit 0a7143c

Please sign in to comment.