Angular: Remove dead code in client #16137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 432c93f. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
ThibaudAV
added
angular
cleanup
ThibaudAV
commented
Sep 23, 2021
| @@ -1,5 +1,4 @@ | |||
| export { computesTemplateSourceFromComponent } from './client/preview/angular-beta/ComputesTemplateFromComponent'; | |||
| export { RendererService } from './client/preview/angular-beta/RendererService'; | |||
There was a problem hiding this comment.
Previously used by docs addon. but now docs use RendererFactory witch return dedicated DocsRenderer instance
ThibaudAV
removed
the
cleanup
Marklb
reviewed
Sep 23, 2021
shilman
changed the title
This code is now longer useful with new RendererFactory
ThibaudAV
force-pushed
the
angular/clean-unused-code
branch
from
c795313
to
432c93f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: n/a
What I did
Remove dead code in client. This code is now longer useful with new RendererFactory
How to test