-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[client-api] Typescript error due to missing types include #11161
Comments
The solution proposed is to add @types/qs to dependencies in https://github.com/storybookjs/storybook/blob/next/lib/client-api/package.json#L42 |
An example where this didn't happen and has that types library |
fixed by #11162 |
@fernandopasik our convention is to close the issues once the fix is released, which happens automatically in my release script if the first line of the PR includes a reference to the issue, e.g. |
@shilman sorry about that, thanks for the clarification, won't happen again |
@fernandopasik no problem! ❤️ |
Huzzah!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-beta.28 containing PR #11162 that references this issue. Upgrade today to try it out! You can find this prerelease on the |
Describe the bug
When checking types on my own project where I use storybook it runs an error indicating that a type of a library used by storybook is missing and treats it like "any"
To Reproduce
run tsc --noEmit in a project that uses storybook
Expected behavior
No errors
Screenshots
Additional context
Latest storybook beta version
The text was updated successfully, but these errors were encountered: