Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client-API: Add @types/qs typings #11162

Merged
merged 1 commit into from Jun 14, 2020
Merged

Client-API: Add @types/qs typings #11162

merged 1 commit into from Jun 14, 2020

Conversation

fernandopasik
Copy link
Member

@fernandopasik fernandopasik commented Jun 13, 2020 •
edited by shilman

Issue: #11161

What I did

Just add a missing type.

How to test

tsc --noEmit in storybook and didn't see an error about that particular case

@github-actions
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against d4e663c

shilman
shilman approved these changes Jun 14, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman changed the title [client-api] add @types/qs Client-API: Add @types/qs typings Jun 14, 2020
@fernandopasik fernandopasik merged commit d28d8b5 into next Jun 14, 2020
@fernandopasik fernandopasik mentioned this pull request Jun 14, 2020
Closed
@fernandopasik fernandopasik deleted the types-qs branch June 14, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
bug typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fernandopasik @shilman