Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Both js and jsx or ts and tsx #10002

Closed
wants to merge 149 commits into from

Conversation

thakursachin467
Copy link
Contributor

Updated Regex to accommodate both Js and JSX or ts and TSX.

Issue:

What I did

Update default template generation in storybook cli to add jsx/ts/tsx file.

AbdelhalimAhmed and others added 30 commits January 20, 2020 01:15
as I have an exception when using yarn with npx i forced it to use npm instead by: ```  --use-npm ```
Typescript: Export IStory in `@storybook/angular`
Fix broken link to repo in empty knobs panel
Addon-docs:  Fix TS false default value in prop table
L56 was missing an `=`, breaking `npm run storybook`
Addon-docs: Revert breaking source indentation fix
This may be intuitive enough to some, but it took me a minute to figure out so I think it'd be nice to have here.
Improve Typescript Configuration documentation page
ndelangen and others added 18 commits February 25, 2020 22:41
FIX storybookjs#8504 - HTML elements get their classes dropped in MDX
…w-files

Storyshots: Fix support for jsx/tsx config files
…-support

Core: Use telejson for websockets channel
…values

Props: Fix typescript unspecified default value
…r-addon-centered

Centered: remove `typesVersions` attribute
docs: add example for more meaningful static storybookUrl file path
Updated Regex to accommodate both Js and JSX or ts and TSX.
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman added the cli label Mar 1, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please target this PR to next?

@shilman shilman added this to the 6.0.0 milestone Mar 1, 2020
@thakursachin467 thakursachin467 changed the base branch from master to next March 1, 2020 05:42
@thakursachin467
Copy link
Contributor Author

Target Branch changed to next. Closing this PR created a new one #10003 . I took the wrong base to create the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet