Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-controls: Fix ArgsTable bugs and styling #11805

Merged
merged 7 commits into from
Aug 5, 2020
Merged

Conversation

domyen
Copy link
Member

@domyen domyen commented Aug 5, 2020

Issue: #11362, #11698

What I did

  • Fixed width of ArgsTable columns when not compact
  • Allow really long code strings to flow to the next line
  • Prevent Boolean (true|false pill button) control from stacking when it's parent width is constrained
  • Some code font-size tweaks
  • Fix missing border style in Safari only Props table does not show border on Safari #11698

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes, look at Chromatic changeset here
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

@domyen domyen changed the title 11362 name column width 11362, 11698 Fix ArgsTable bugs and styling Aug 5, 2020
@domyen domyen changed the title 11362, 11698 Fix ArgsTable bugs and styling #11362, #11698 Fix ArgsTable bugs and styling Aug 5, 2020
@shilman shilman changed the title #11362, #11698 Fix ArgsTable bugs and styling Addon-controls: Fix ArgsTable bugs and styling Aug 5, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only question is why we are hardcoding font size rather than inheriting from the parent element? This seems brittle and in the past we've had to fix it e.g. #11770

@domyen
Copy link
Member Author

domyen commented Aug 5, 2020

@shilman I acknowledge that setting absolute values negates the ability to set one font-size at the top level and have it get inherited everywhere. But relative units can make it tough to apply precise sizing and debug what the resultant font-size is. You end up with values like font-size: 92.8%; and font-size:85.7% to represent 13px and 12px respectively.

This came up in another issue with relative line-heights. I guess there's a tradeoff here.

@shilman shilman merged commit b518502 into next Aug 5, 2020
@stof stof deleted the 11362-name-column-width branch May 25, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants