Addon-docs: Add classnames for Preview block #14685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
approved these changes
Apr 22, 2021
Ayushsunny
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
Awesome idea looks good to me!
You can say it's working from this message in the build: https://github.com/storybookjs/storybook/pull/14685/checks
But make sure that finishes with ✔️. After that, it should be good to merge
ndelangen
requested changes
Apr 22, 2021
ndelangen
reviewed
Apr 23, 2021
ndelangen
approved these changes
Apr 23, 2021
|
ODD CI failure, asking @shilman to take a look. |
Nx Cloud ReportCI ran the following commands for commit 19c2934. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #14673
What I did
I've added className for
Show/Hide codetoggle and forCopybutton of thePreviewblockHow to test
If your answer is yes to any of these, please make sure to include it in your PR.