[addon-a11y] Fix best practices added in #14736 #14754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaelig
force-pushed
the
best-practices-a11y-redux
branch
from
a613300
to
eed779a
Compare
Nx Cloud ReportCI ran the following commands for commit 71cfb5b. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
|
@tooppaaa @adagar @jsomsanith any chance you can give a thorough review here? will be great to get more a11y process stuff documented for storybook 🙏 |
tooppaaa
approved these changes
Apr 29, 2021
|
Thanks for this awesome documentation and guidelines @kaelig ! |
jsomsanith
reviewed
Apr 29, 2021
|
Nice improvement. Just a typo ☝️ |
|
Thank you very much, and apologies for the first PR riddled with wrong code! |
shilman
added
documentation
patch:yes
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
May 8, 2021
[addon-a11y] Fix best practices added in #14736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: in #14736, I added content that had a few issues 😨
This time, let’s get it right and gather feedback from a few more folks before merging. I'd appreciate a thorough review and opinions on these best practices I'm advocating for.