-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Add core.channelOptions
to main.js config
#16415
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giving users the ability to optimize the channel default options for security of performance reasons
Nx Cloud ReportCI ran the following commands for commit fd21119. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
shilman
changed the title
Add global.CHANNEL_OPTIONS which can be configured in main.js
Core: Add Oct 20, 2021
core.channelOptions
main.js config
shilman
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great @ndelangen 🙌
shilman
requested changes
Oct 20, 2021
Co-authored-by: Michael Shilman <shilman@users.noreply.github.com>
shilman
reviewed
Oct 20, 2021
Co-authored-by: Michael Shilman <shilman@users.noreply.github.com>
shilman
approved these changes
Oct 20, 2021
shilman
changed the title
Core: Add
Core: Add Oct 20, 2021
core.channelOptions
main.js configcore.channelOptions
to main.js config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #12364
giving users the ability to optimize the channel default options for security of performance reasons
What I did
How to test