Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Add core.channelOptions to main.js config #16415

Merged
merged 6 commits into from Oct 20, 2021
Merged

Core: Add core.channelOptions to main.js config #16415

merged 6 commits into from Oct 20, 2021

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Oct 20, 2021 •
edited by shilman

Issue: #12364

giving users the ability to optimize the channel default options for security of performance reasons

What I did

  • allow users to define custom config for the storybook channel.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

@ndelangen
Add global.CHANNEL_OPTIONS coming from main.js > core > channelOptions
cc141dc 
giving users the ability to optimize the channel default options for security of performance reasons
@nx-cloud
Copy link

nx-cloud bot commented Oct 20, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit fd21119. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@ndelangen ndelangen self-assigned this Oct 20, 2021
@shilman shilman changed the title Add global.CHANNEL_OPTIONS which can be configured in main.js Core: Add core.channelOptions main.js config Oct 20, 2021
shilman
shilman approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @ndelangen 🙌

@ndelangen @shilman
Update lib/builder-webpack4/src/preview/iframe-webpack.config.ts
48b2408 
Co-authored-by: Michael Shilman <shilman@users.noreply.github.com>
@ndelangen @shilman
Update lib/builder-webpack5/src/preview/iframe-webpack.config.ts
fd21119 
Co-authored-by: Michael Shilman <shilman@users.noreply.github.com>
@shilman shilman merged commit 6980d27 into next Oct 20, 2021
@shilman shilman deleted the fix/12364-give-users-channeloptions-in-mainjs branch October 20, 2021 16:40
@shilman shilman changed the title Core: Add core.channelOptions main.js config Core: Add core.channelOptions to main.js config Oct 20, 2021
@shilman shilman mentioned this pull request Oct 21, 2021
Closed
@shilman shilman added this to the 6.4 PRs milestone Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees

@ndelangen ndelangen

Labels
core feature request security
Projects
None yet
Milestone
6.4 PRs
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ndelangen @shilman