Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech: ESLint allow devDependencies imports in prebundled packages #20440

Merged
merged 6 commits into from
Dec 30, 2022

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Dec 29, 2022

Issue:

What I did

I saw a bunch of disable comments for eslint-import/no-extraneous-deps because we pre-bundle most packages, which means we can use dependencies from devDependencies, not just dependencies.

This updates the eslint config to allow devDependencies to be used in all but ember, angular, and core-server (which don't pre-bundle). It also enables the eslint-comments/no-unused-disable rule, to help find previously-disabled imports.

How to test

  • linting in CI

@IanVS IanVS added the build Internal-facing build tooling & test updates label Dec 29, 2022
@valentinpalkovic valentinpalkovic merged commit e0c1dee into next Dec 30, 2022
@valentinpalkovic valentinpalkovic deleted the eslint-extraneous-deps branch December 30, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants