Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Don't warn if we find the same entry twice. #21403

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Mar 6, 2023

Closes #21373

What I did

Don't warn if we find the same entry (by import path) twice; this can mean it's specified twice. E.g.

    '../src/docs/Introduction.mdx',
    '../src/docs/*.mdx',

How to test

Update a sandbox to include:

"stories": ["../src/stories/Introduction.mdx", "../src/**/*.mdx", "../src/**/*.stories.@(js|jsx|ts|tsx)", {`

Double check it doesn't warn.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@tmeasday tmeasday requested a review from shilman March 6, 2023 00:10
@tmeasday tmeasday closed this Mar 6, 2023
@tmeasday tmeasday force-pushed the 21373-no-duplicate-warning-for-same-file branch from 7de718e to 29a33ed Compare March 6, 2023 06:08
@tmeasday tmeasday reopened this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants