Ember: Fix broken import #21435

yannbertrand · 2023-03-06T22:18:55Z

Hopefully closes #20653

What I did

Ember recommends to use @glimmer/component rather than @ember/component. I switched the import and the package.json accordingly. I believe ember itself somehow import @glimmer/component so maybe the peer dependency is not needed. I couldn't launch the project myself locally so let's wait for CI check.

How to test

Create a fresh app Ember

npx --package ember-cli ember --version #ember-cli: 4.11.0
npx --package ember-cli ember new ember-quickstart

Check Ember app works fine

cd ember-quickstart
npm start

Install this storybook PR for Ember

npm install --save-dev yannbertrand/storybook#next

Init Storybook

npx storybook --version #
npx storybook init

Hopefully this command now works and render something

npm run storybook

Checklist

Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
Make sure to add/update documentation regarding your changes
If you are deprecating/removing a feature, make sure to update
MIGRATION.MD

Maintainers

If this PR should be tested against many or all sandboxes,
make sure to add the ci:merged or ci:daily GH label to it.
Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

dbendaou · 2023-03-07T10:16:41Z

code/frameworks/ember/src/client/preview/render.ts

@@ -2,7 +2,7 @@ import { global } from '@storybook/global';
 import { dedent } from 'ts-dedent';
 import type { RenderContext } from '@storybook/types';
 // @ts-expect-error (Converted from ts-ignore)


I guess we can remove this line types for @glimmer should be defined

dbendaou · 2023-03-07T12:56:13Z

Changes look good to me, did you had the opportunity to try with yarn link or something like this?

The CI was already not breaking last time and I've introduced the bug so I better be extra careful :)

socket-security · 2023-03-10T13:50:34Z

Socket Security Pull Request Report

Dependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again.

⚠️ Uses eval

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Package	Eval Type	Location	Source
ember-source@4.11.0 (added)	Function	dist/ember-template-compiler.js	`code/frameworks/ember/package.json`
ember-source@4.11.0 (added)	Function	dist/ember-template-compiler.js	`code/frameworks/ember/package.json`
ember-source@4.11.0 (added)	Function	dist/packages/@ember/-internals/container/index.js	`code/frameworks/ember/package.json`
ember-source@4.11.0 (added)	Function	dist/packages/@ember/-internals/environment/index.js	`code/frameworks/ember/package.json`
envinfo@7.8.1 (added)	Function	dist/envinfo.js	`code/package.json` via @storybook/cli@6.5.16, lerna@6.5.1, `code/lib/cli/package.json`, `scripts/package.json` via verdaccio@5.22.1, `test-storybooks/ember-cli/package.json` via storybook@7.0.0-alpha.43, webpack-cli@4.10.0, `test-storybooks/external-docs/package.json` via storybook@7.0.0-alpha.43, `test-storybooks/server-kitchen-sink/package.json` via storybook@7.0.0-alpha.43, `test-storybooks/standalone-preview/package.json` via @storybook/cli@7.0.0-alpha.43, storybook@7.0.0-alpha.43
envinfo@7.8.1 (added)	Function	dist/envinfo.js	`code/package.json` via @storybook/cli@6.5.16, lerna@6.5.1, `code/lib/cli/package.json`, `scripts/package.json` via verdaccio@5.22.1, `test-storybooks/ember-cli/package.json` via storybook@7.0.0-alpha.43, webpack-cli@4.10.0, `test-storybooks/external-docs/package.json` via storybook@7.0.0-alpha.43, `test-storybooks/server-kitchen-sink/package.json` via storybook@7.0.0-alpha.43, `test-storybooks/standalone-preview/package.json` via @storybook/cli@7.0.0-alpha.43, storybook@7.0.0-alpha.43
es5-ext@0.10.62 (added)	Function	function/_define-length.js	`test-storybooks/external-docs/package.json` via nextra-theme-docs@1.2.6
es5-ext@0.10.62 (added)	Function	function/#/copy.js	`test-storybooks/external-docs/package.json` via nextra-theme-docs@1.2.6
es5-ext@0.10.62 (added)	Function	object/unserialize.js	`test-storybooks/external-docs/package.json` via nextra-theme-docs@1.2.6
esbuild-register@3.4.2 (added)	Function	dist/node.js	`code/lib/core-common/package.json`, `scripts/package.json`, `test-storybooks/ember-cli/package.json` via @storybook/addon-controls@7.0.0-alpha.43, @storybook/addon-docs@7.0.0-alpha.43, @storybook/ember@7.0.0-alpha.43, storybook@7.0.0-alpha.43, `test-storybooks/external-docs/package.json` via @storybook/addon-docs@7.0.0-alpha.43, @storybook/addon-essentials@7.0.0-alpha.43, @storybook/blocks@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, `test-storybooks/server-kitchen-sink/package.json` via @storybook/addon-controls@7.0.0-alpha.43, @storybook/server-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, `test-storybooks/standalone-preview/package.json` via @storybook/addon-docs@7.0.0-alpha.43, @storybook/cli@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43
expect@27.5.1 (added)	Function	build/index.js	`code/package.json` via @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/preset-create-react-app@4.1.2, `code/presets/create-react-app/package.json` via react-scripts@5.0.1
expect@27.5.1 (added)	Function	build/index.js	`code/package.json` via @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/preset-create-react-app@4.1.2, `code/presets/create-react-app/package.json` via react-scripts@5.0.1
expect@27.5.1 (added)	Function	build/index.js	`code/package.json` via @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/preset-create-react-app@4.1.2, `code/presets/create-react-app/package.json` via react-scripts@5.0.1
expect@27.5.1 (added)	Function	build/utils.js	`code/package.json` via @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/preset-create-react-app@4.1.2, `code/presets/create-react-app/package.json` via react-scripts@5.0.1
fast-redact@3.1.2 (added)	Function	lib/redactor.js	`scripts/package.json` via verdaccio@5.22.1
fast-redact@3.1.2 (added)	Function	lib/restorer.js	`scripts/package.json` via verdaccio@5.22.1
handlebars@2.0.0 (added)	Function	dist/cjs/handlebars/compiler/javascript-compiler.js	`test-storybooks/ember-cli/package.json` via ember-template-compiler@1.9.0-alpha
handlebars@2.0.0 (added)	Function	lib/handlebars/compiler/javascript-compiler.js	`test-storybooks/ember-cli/package.json` via ember-template-compiler@1.9.0-alpha
handlebars@4.7.7 (added)	Function	dist/cjs/handlebars/compiler/javascript-compiler.js	`code/package.json` via @storybook/addon-controls@6.5.16, @storybook/addon-docs@6.5.16, @storybook/addon-essentials@6.5.16, @storybook/addon-interactions@6.5.16, @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/angular@6.5.16, @storybook/builder-vite@0.4.2, @storybook/builder-webpack5@6.5.16, @storybook/cli@6.5.16, @storybook/core-common@6.5.16, @storybook/core-server@6.5.16, @storybook/ember@6.5.16, @storybook/html@6.5.16, @storybook/preact@6.5.16, @storybook/preset-create-react-app@4.1.2, @storybook/react@6.5.16, @storybook/server@6.5.16, @storybook/svelte@6.5.16, @storybook/telemetry@6.5.16, @storybook/vue@6.5.16, @storybook/vue3@6.5.16, @storybook/web-components@6.5.16, lerna@6.5.1, `code/frameworks/ember/package.json` via ember-source@4.11.0, `code/lib/core-common/package.json`, `scripts/package.json` via verdaccio@5.22.1, `test-storybooks/ember-cli/package.json` via @storybook/addon-controls@7.0.0-alpha.43, @storybook/addon-docs@7.0.0-alpha.43, @storybook/ember@7.0.0-alpha.43, ember-cli@3.24.0, storybook@7.0.0-alpha.43, `test-storybooks/external-docs/package.json` via @storybook/addon-docs@7.0.0-alpha.43, @storybook/addon-essentials@7.0.0-alpha.43, @storybook/blocks@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, `test-storybooks/server-kitchen-sink/package.json` via @storybook/addon-controls@7.0.0-alpha.43, @storybook/server-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, `test-storybooks/standalone-preview/package.json` via @storybook/addon-docs@7.0.0-alpha.43, @storybook/cli@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43
handlebars@4.7.7 (added)	Function	dist/cjs/handlebars/compiler/javascript-compiler.js	`code/package.json` via @storybook/addon-controls@6.5.16, @storybook/addon-docs@6.5.16, @storybook/addon-essentials@6.5.16, @storybook/addon-interactions@6.5.16, @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/angular@6.5.16, @storybook/builder-vite@0.4.2, @storybook/builder-webpack5@6.5.16, @storybook/cli@6.5.16, @storybook/core-common@6.5.16, @storybook/core-server@6.5.16, @storybook/ember@6.5.16, @storybook/html@6.5.16, @storybook/preact@6.5.16, @storybook/preset-create-react-app@4.1.2, @storybook/react@6.5.16, @storybook/server@6.5.16, @storybook/svelte@6.5.16, @storybook/telemetry@6.5.16, @storybook/vue@6.5.16, @storybook/vue3@6.5.16, @storybook/web-components@6.5.16, lerna@6.5.1, `code/frameworks/ember/package.json` via ember-source@4.11.0, `code/lib/core-common/package.json`, `scripts/package.json` via verdaccio@5.22.1, `test-storybooks/ember-cli/package.json` via @storybook/addon-controls@7.0.0-alpha.43, @storybook/addon-docs@7.0.0-alpha.43, @storybook/ember@7.0.0-alpha.43, ember-cli@3.24.0, storybook@7.0.0-alpha.43, `test-storybooks/external-docs/package.json` via @storybook/addon-docs@7.0.0-alpha.43, @storybook/addon-essentials@7.0.0-alpha.43, @storybook/blocks@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, `test-storybooks/server-kitchen-sink/package.json` via @storybook/addon-controls@7.0.0-alpha.43, @storybook/server-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, `test-storybooks/standalone-preview/package.json` via @storybook/addon-docs@7.0.0-alpha.43, @storybook/cli@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43
handlebars@4.7.7 (added)	Function	dist/handlebars.amd.js	`code/package.json` via @storybook/addon-controls@6.5.16, @storybook/addon-docs@6.5.16, @storybook/addon-essentials@6.5.16, @storybook/addon-interactions@6.5.16, @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/angular@6.5.16, @storybook/builder-vite@0.4.2, @storybook/builder-webpack5@6.5.16, @storybook/cli@6.5.16, @storybook/core-common@6.5.16, @storybook/core-server@6.5.16, @storybook/ember@6.5.16, @storybook/html@6.5.16, @storybook/preact@6.5.16, @storybook/preset-create-react-app@4.1.2, @storybook/react@6.5.16, @storybook/server@6.5.16, @storybook/svelte@6.5.16, @storybook/telemetry@6.5.16, @storybook/vue@6.5.16, @storybook/vue3@6.5.16, @storybook/web-components@6.5.16, lerna@6.5.1, `code/frameworks/ember/package.json` via ember-source@4.11.0, `code/lib/core-common/package.json`, `scripts/package.json` via verdaccio@5.22.1, `test-storybooks/ember-cli/package.json` via @storybook/addon-controls@7.0.0-alpha.43, @storybook/addon-docs@7.0.0-alpha.43, @storybook/ember@7.0.0-alpha.43, ember-cli@3.24.0, storybook@7.0.0-alpha.43, `test-storybooks/external-docs/package.json` via @storybook/addon-docs@7.0.0-alpha.43, @storybook/addon-essentials@7.0.0-alpha.43, @storybook/blocks@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, `test-storybooks/server-kitchen-sink/package.json` via @storybook/addon-controls@7.0.0-alpha.43, @storybook/server-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, `test-storybooks/standalone-preview/package.json` via @storybook/addon-docs@7.0.0-alpha.43, @storybook/cli@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43
handlebars@4.7.7 (added)	Function	dist/handlebars.amd.js	`code/package.json` via @storybook/addon-controls@6.5.16, @storybook/addon-docs@6.5.16, @storybook/addon-essentials@6.5.16, @storybook/addon-interactions@6.5.16, @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/angular@6.5.16, @storybook/builder-vite@0.4.2, @storybook/builder-webpack5@6.5.16, @storybook/cli@6.5.16, @storybook/core-common@6.5.16, @storybook/core-server@6.5.16, @storybook/ember@6.5.16, @storybook/html@6.5.16, @storybook/preact@6.5.16, @storybook/preset-create-react-app@4.1.2, @storybook/react@6.5.16, @storybook/server@6.5.16, @storybook/svelte@6.5.16, @storybook/telemetry@6.5.16, @storybook/vue@6.5.16, @storybook/vue3@6.5.16, @storybook/web-components@6.5.16, lerna@6.5.1, `code/frameworks/ember/package.json` via ember-source@4.11.0, `code/lib/core-common/package.json`, `scripts/package.json` via verdaccio@5.22.1, `test-storybooks/ember-cli/package.json` via @storybook/addon-controls@7.0.0-alpha.43, @storybook/addon-docs@7.0.0-alpha.43, @storybook/ember@7.0.0-alpha.43, ember-cli@3.24.0, storybook@7.0.0-alpha.43, `test-storybooks/external-docs/package.json` via @storybook/addon-docs@7.0.0-alpha.43, @storybook/addon-essentials@7.0.0-alpha.43, @storybook/blocks@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, `test-storybooks/server-kitchen-sink/package.json` via @storybook/addon-controls@7.0.0-alpha.43, @storybook/server-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, `test-storybooks/standalone-preview/package.json` via @storybook/addon-docs@7.0.0-alpha.43, @storybook/cli@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43
handlebars@4.7.7 (added)	Function	dist/handlebars.amd.min.js	`code/package.json` via @storybook/addon-controls@6.5.16, @storybook/addon-docs@6.5.16, @storybook/addon-essentials@6.5.16, @storybook/addon-interactions@6.5.16, @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/angular@6.5.16, @storybook/builder-vite@0.4.2, @storybook/builder-webpack5@6.5.16, @storybook/cli@6.5.16, @storybook/core-common@6.5.16, @storybook/core-server@6.5.16, @storybook/ember@6.5.16, @storybook/html@6.5.16, @storybook/preact@6.5.16, @storybook/preset-create-react-app@4.1.2, @storybook/react@6.5.16, @storybook/server@6.5.16, @storybook/svelte@6.5.16, @storybook/telemetry@6.5.16, @storybook/vue@6.5.16, @storybook/vue3@6.5.16, @storybook/web-components@6.5.16, lerna@6.5.1, `code/frameworks/ember/package.json` via ember-source@4.11.0, `code/lib/core-common/package.json`, `scripts/package.json` via verdaccio@5.22.1, `test-storybooks/ember-cli/package.json` via @storybook/addon-controls@7.0.0-alpha.43, @storybook/addon-docs@7.0.0-alpha.43, @storybook/ember@7.0.0-alpha.43, ember-cli@3.24.0, storybook@7.0.0-alpha.43, `test-storybooks/external-docs/package.json` via @storybook/addon-docs@7.0.0-alpha.43, @storybook/addon-essentials@7.0.0-alpha.43, @storybook/blocks@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, `test-storybooks/server-kitchen-sink/package.json` via @storybook/addon-controls@7.0.0-alpha.43, @storybook/server-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, `test-storybooks/standalone-preview/package.json` via @storybook/addon-docs@7.0.0-alpha.43, @storybook/cli@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43
handlebars@4.7.7 (added)	Function	dist/handlebars.amd.min.js	`code/package.json` via @storybook/addon-controls@6.5.16, @storybook/addon-docs@6.5.16, @storybook/addon-essentials@6.5.16, @storybook/addon-interactions@6.5.16, @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/angular@6.5.16, @storybook/builder-vite@0.4.2, @storybook/builder-webpack5@6.5.16, @storybook/cli@6.5.16, @storybook/core-common@6.5.16, @storybook/core-server@6.5.16, @storybook/ember@6.5.16, @storybook/html@6.5.16, @storybook/preact@6.5.16, @storybook/preset-create-react-app@4.1.2, @storybook/react@6.5.16, @storybook/server@6.5.16, @storybook/svelte@6.5.16, @storybook/telemetry@6.5.16, @storybook/vue@6.5.16, @storybook/vue3@6.5.16, @storybook/web-components@6.5.16, lerna@6.5.1, `code/frameworks/ember/package.json` via ember-source@4.11.0, `code/lib/core-common/package.json`, `scripts/package.json` via verdaccio@5.22.1, `test-storybooks/ember-cli/package.json` via @storybook/addon-controls@7.0.0-alpha.43, @storybook/addon-docs@7.0.0-alpha.43, @storybook/ember@7.0.0-alpha.43, ember-cli@3.24.0, storybook@7.0.0-alpha.43, `test-storybooks/external-docs/package.json` via @storybook/addon-docs@7.0.0-alpha.43, @storybook/addon-essentials@7.0.0-alpha.43, @storybook/blocks@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, `test-storybooks/server-kitchen-sink/package.json` via @storybook/addon-controls@7.0.0-alpha.43, @storybook/server-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, `test-storybooks/standalone-preview/package.json` via @storybook/addon-docs@7.0.0-alpha.43, @storybook/cli@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43
is-callable@1.2.7 (added)	Function	test/index.js	`code/package.json` via @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/angular@6.5.16, @storybook/builder-vite@0.4.2, @storybook/core-client@6.5.16, @storybook/core-server@6.5.16, @storybook/ember@6.5.16, @storybook/eslint-config-storybook@3.1.2, @storybook/html@6.5.16, @storybook/jest@0.0.10, @storybook/linter-config@3.1.2, @storybook/preact@6.5.16, @storybook/preset-create-react-app@4.1.2, @storybook/react@6.5.16, @storybook/server@6.5.16, @storybook/svelte@6.5.16, @storybook/testing-library@0.0.13, @storybook/vue@6.5.16, @storybook/vue3@6.5.16, @storybook/web-components@6.5.16, @testing-library/jest-dom@5.16.5, eslint-import-resolver-typescript@3.5.3, eslint-plugin-import@2.27.5, eslint-plugin-react@7.32.2, util@0.12.5, `code/addons/interactions/package.json` via @storybook/jest@0.0.10, @storybook/testing-library@0.0.13, `code/addons/storyshots-core/package.json` via enzyme@3.11.0, enzyme-adapter-react-16@1.15.7, enzyme-to-json@3.6.2, `code/addons/storyshots-puppeteer/package.json` via enzyme@3.11.0, enzyme-to-json@3.6.2, `code/frameworks/ember/package.json` via babel-plugin-htmlbars-inline-precompile@5.3.1, ember-source@4.11.0, `code/frameworks/vue-vite/package.json` via vue-docgen-api@4.60.0, `code/frameworks/vue3-vite/package.json` via vue-docgen-api@4.60.0, `code/frameworks/vue3-webpack5/package.json` via @storybook/preset-vue3-webpack@7.0.0-rc.1, `code/lib/builder-manager/package.json` via util@0.12.5, `code/lib/builder-vite/package.json` via vite-plugin-glimmerx@0.6.6, `code/lib/builder-webpack5/package.json` via util@0.12.5, `code/lib/codemod/package.json` via recast@0.23.1, util@0.12.5, `code/lib/csf-tools/package.json` via recast@0.23.1, `code/presets/create-react-app/package.json` via react-scripts@5.0.1, `code/presets/vue-webpack/package.json` via vue-docgen-api@4.60.0, vue-docgen-loader@1.5.1, `code/presets/vue3-webpack/package.json` via vue-docgen-api@4.60.0, vue-docgen-loader@1.5.1, `scripts/package.json` via @storybook/eslint-config-storybook@3.1.2, @storybook/jest@0.0.10, @storybook/linter-config@3.1.2, @storybook/testing-library@0.0.13, @testing-library/jest-dom@5.16.5, eslint-plugin-import@2.27.5, eslint-plugin-react@7.32.2, recast@0.23.1, util@0.12.5, `test-storybooks/ember-cli/package.json` via @storybook/ember@7.0.0-alpha.43, storybook@7.0.0-alpha.43, `test-storybooks/external-docs/package.json` via @storybook/react-webpack5@7.0.0-alpha.43, eslint-config-next@12.0.8, storybook@7.0.0-alpha.43, `test-storybooks/server-kitchen-sink/package.json` via [@s

yannbertrand · 2023-03-10T14:41:13Z

Changes look good to me, did you had the opportunity to try with yarn link or something like this?

The CI was already not breaking last time and I've introduced the bug so I better be extra careful :)

Actually we tried, but I'm not sure on how to fully test this. Here are the steps I followed:

Build and link `@storybook/ember`

cd storybook/scripts
yarn install 
cd ../code
yarn install
yarn build ember
cd frameworks/ember
npm link

Init Ember project and Storybook

npx --package ember-cli ember new ember-quickstart
cd ember-quickstart

# I don't know how to link the CLI, so I `init` using production build
npx --package storybook@^6 storybook init # n, n

npm link @storybook/ember
npm run storybook

Looking into my node_modules folder, @storybook/ember seems properly linked.

But I get this error:

> ember-quickstart@0.0.0 storybook
> start-storybook -p 6006 -s dist

sh: start-storybook: command not found

How can I go further in my work?

yannbertrand · 2023-03-13T09:17:08Z

But I get this error:

> ember-quickstart@0.0.0 storybook
> start-storybook -p 6006 -s dist

sh: start-storybook: command not found

I believe this one happens because my local fork is Storybook@v7, so start-storybook doesn't exist anymore. Is there any way to fix Storybook@v6 before adressing v7?

dbendaou · 2023-03-13T17:04:08Z

I think you would need to try the fix on 6.15 version instead of the next branch, since the next branch already have some changes for Storybook v7 that weren't tested yet on Ember

yannbertrand · 2023-03-14T17:00:48Z

So I have no idea on how to fix this. The Ember example throws a lot of warnings. Upgrading to new versions totally breaks and we're not even in the latest major one.

If I understand it correctly, Ember team looks to know about it. I hope they can fix it.

I'm closing my PR.

jonniebigodes added the ember label Mar 6, 2023

dbendaou reviewed Mar 7, 2023

View reviewed changes

yannbertrand force-pushed the next branch from 780da53 to fa344b5 Compare March 7, 2023 11:09

Use @glimmer/component rather than @ember/component

5caecd8

nlepage force-pushed the next branch 2 times, most recently from e06da68 to 5caecd8 Compare March 8, 2023 14:27

Bump ember-source dep

2a95ac7

kylegach assigned shilman Mar 13, 2023

shilman changed the title ~~fix: Ember broken import~~ Ember: Fix broken import Mar 13, 2023

shilman added the maintenance User-facing maintenance tasks label Mar 13, 2023

yannbertrand mentioned this pull request Mar 13, 2023

Ember: Fix broken import #21580

Closed

5 tasks

yannbertrand marked this pull request as draft March 14, 2023 09:47

yannbertrand closed this Mar 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ember: Fix broken import #21435

Ember: Fix broken import #21435

yannbertrand commented Mar 6, 2023 •

edited

dbendaou Mar 7, 2023 •

edited

yannbertrand Mar 7, 2023

dbendaou commented Mar 7, 2023

socket-security bot commented Mar 10, 2023

yannbertrand commented Mar 10, 2023

yannbertrand commented Mar 13, 2023

dbendaou commented Mar 13, 2023

yannbertrand commented Mar 14, 2023

Ember: Fix broken import #21435

Ember: Fix broken import #21435

Conversation

yannbertrand commented Mar 6, 2023 • edited

What I did

How to test

Checklist

Maintainers

dbendaou Mar 7, 2023 • edited

Choose a reason for hiding this comment

yannbertrand Mar 7, 2023

Choose a reason for hiding this comment

dbendaou commented Mar 7, 2023

socket-security bot commented Mar 10, 2023

Socket Security Pull Request Report

yannbertrand commented Mar 10, 2023

Build and link @storybook/ember

Init Ember project and Storybook

yannbertrand commented Mar 13, 2023

dbendaou commented Mar 13, 2023

yannbertrand commented Mar 14, 2023

yannbertrand commented Mar 6, 2023 •

edited

dbendaou Mar 7, 2023 •

edited

Build and link `@storybook/ember`