Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix duplicated dependency warning for major version differences #21850

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Mar 31, 2023

Closes #21849

What I did

The automigration will now only promote duplicated dependencies to "critical" if they differ in major and are part of the disallowlist.

How to test

  1. See the tests

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added maintenance User-facing maintenance tasks cli labels Mar 31, 2023
@shilman shilman changed the title CLI: Only provide critical duplicated dependency warning on major version differences CLI: Fix duplicated dependency warning for major version differences Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dial back version conflict warnings
2 participants