Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix TOC stories for cra/default-js #23349

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 7, 2023

Closes N/A

What I did

cra/default-js is failing when TS stories reference other TS stories.

This will probably need to be solved properly in the future, but in the short term I'm just fixing the problem by brute force. I tested locally & could reproduce the CI error and the fix.

Self-merging @valentinpalkovic

How to test

  • CI passes

@shilman shilman added build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. labels Jul 7, 2023
@shilman shilman merged commit 1f782f3 into next Jul 7, 2023
25 of 28 checks passed
@shilman shilman deleted the shilman/fix-toc-stories branch July 7, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant