Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: Fix AppRouterProvider usage #25032

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

valentinpalkovic
Copy link
Contributor

Closes #25016

What I did

Removed the dynamic loading of the AppRouterProvider to fix an issue with preview hooks.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic added bug nextjs ci:daily Run the CI jobs that normally run in the daily job. upgrade:7.6 labels Nov 29, 2023
@valentinpalkovic valentinpalkovic self-assigned this Nov 29, 2023
@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Nov 29, 2023
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an elegant solution!

@valentinpalkovic valentinpalkovic merged commit ab4e5ed into next Nov 29, 2023
107 of 109 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/fix-app-router-in-nextjs branch November 29, 2023 10:25
storybook-bot pushed a commit that referenced this pull request Nov 29, 2023
…-nextjs

Next.js: Fix AppRouterProvider usage

(cherry picked from commit ab4e5ed)
@terrymun
Copy link

Thanks for the very quick fix! ❤️

storybook-bot pushed a commit that referenced this pull request Nov 29, 2023
…-nextjs

Next.js: Fix AppRouterProvider usage

(cherry picked from commit ab4e5ed)
storybook-bot pushed a commit that referenced this pull request Nov 29, 2023
…-nextjs

Next.js: Fix AppRouterProvider usage

(cherry picked from commit ab4e5ed)
storybook-bot pushed a commit that referenced this pull request Nov 29, 2023
…-nextjs

Next.js: Fix AppRouterProvider usage

(cherry picked from commit ab4e5ed)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 29, 2023
@github-actions github-actions bot mentioned this pull request Dec 7, 2023
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job. nextjs patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch upgrade:7.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Setting nextjs.appDirectory to true causes error on 7.6.0
3 participants