Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Upgrade esbuild (0.20.1) #26255

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Build: Upgrade esbuild (0.20.1) #26255

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e29d22b
chore: upgrade esbuild to 0.20.1
43081j Feb 29, 2024
93a3159
Merge branch 'next' into esbuild
ndelangen Mar 5, 2024
c4956e2
broaden version range for vite compatibility
ndelangen Mar 5, 2024
3f3eb2c
Merge branch 'next' into pr/43081j/26255
ndelangen Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/builders/builder-manager/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"@yarnpkg/esbuild-plugin-pnp": "^3.0.0-rc.10",
"browser-assert": "^1.2.1",
"ejs": "^3.1.8",
"esbuild": "^0.18.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valentinpalkovic do you remember why we are on 0.18? I reckon something happened in the past but I just don't remember

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly have no clue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the best way to prove everything is fine other than CI being happy?

if you can point me in the right direction, i can try do further testing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We upgraded it last 9 months ago.

Screenshot 2024-03-05 at 14 21 48

#21727

It might just have been a hiccup with mixed versions.

This LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm,.. maybe this:
#26112

"esbuild": "^0.20.1",
"esbuild-plugin-alias": "^0.2.1",
"express": "^4.17.3",
"fs-extra": "^11.1.0",
Expand Down
2 changes: 1 addition & 1 deletion code/lib/core-common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"@yarnpkg/libzip": "2.3.0",
"chalk": "^4.1.0",
"cross-spawn": "^7.0.3",
"esbuild": "^0.18.0",
"esbuild": "^0.20.1",
"esbuild-register": "^3.5.0",
"execa": "^5.0.0",
"file-system-cache": "2.3.0",
Expand Down
2 changes: 1 addition & 1 deletion code/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
"@storybook/theming": "workspace:*",
"@types/node": "^18.0.0",
"@vitest/expect@1.1.3": "patch:@vitest/expect@npm%3A1.1.3#~/.yarn/patches/@vitest-expect-npm-1.1.3-2062bf533f.patch",
"esbuild": "^0.18.0",
"esbuild": "^0.20.1",
"playwright": "1.36.0",
"playwright-core": "1.36.0",
"serialize-javascript": "^3.1.0",
Expand Down
200 changes: 105 additions & 95 deletions code/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2583,156 +2583,163 @@ __metadata:
languageName: node
linkType: hard

"@esbuild/android-arm64@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/android-arm64@npm:0.18.20"
"@esbuild/aix-ppc64@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/aix-ppc64@npm:0.20.1"
conditions: os=aix & cpu=ppc64
languageName: node
linkType: hard

"@esbuild/android-arm64@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/android-arm64@npm:0.20.1"
conditions: os=android & cpu=arm64
languageName: node
linkType: hard

"@esbuild/android-arm@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/android-arm@npm:0.18.20"
"@esbuild/android-arm@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/android-arm@npm:0.20.1"
conditions: os=android & cpu=arm
languageName: node
linkType: hard

"@esbuild/android-x64@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/android-x64@npm:0.18.20"
"@esbuild/android-x64@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/android-x64@npm:0.20.1"
conditions: os=android & cpu=x64
languageName: node
linkType: hard

"@esbuild/darwin-arm64@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/darwin-arm64@npm:0.18.20"
"@esbuild/darwin-arm64@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/darwin-arm64@npm:0.20.1"
conditions: os=darwin & cpu=arm64
languageName: node
linkType: hard

"@esbuild/darwin-x64@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/darwin-x64@npm:0.18.20"
"@esbuild/darwin-x64@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/darwin-x64@npm:0.20.1"
conditions: os=darwin & cpu=x64
languageName: node
linkType: hard

"@esbuild/freebsd-arm64@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/freebsd-arm64@npm:0.18.20"
"@esbuild/freebsd-arm64@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/freebsd-arm64@npm:0.20.1"
conditions: os=freebsd & cpu=arm64
languageName: node
linkType: hard

"@esbuild/freebsd-x64@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/freebsd-x64@npm:0.18.20"
"@esbuild/freebsd-x64@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/freebsd-x64@npm:0.20.1"
conditions: os=freebsd & cpu=x64
languageName: node
linkType: hard

"@esbuild/linux-arm64@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/linux-arm64@npm:0.18.20"
"@esbuild/linux-arm64@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/linux-arm64@npm:0.20.1"
conditions: os=linux & cpu=arm64
languageName: node
linkType: hard

"@esbuild/linux-arm@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/linux-arm@npm:0.18.20"
"@esbuild/linux-arm@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/linux-arm@npm:0.20.1"
conditions: os=linux & cpu=arm
languageName: node
linkType: hard

"@esbuild/linux-ia32@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/linux-ia32@npm:0.18.20"
"@esbuild/linux-ia32@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/linux-ia32@npm:0.20.1"
conditions: os=linux & cpu=ia32
languageName: node
linkType: hard

"@esbuild/linux-loong64@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/linux-loong64@npm:0.18.20"
"@esbuild/linux-loong64@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/linux-loong64@npm:0.20.1"
conditions: os=linux & cpu=loong64
languageName: node
linkType: hard

"@esbuild/linux-mips64el@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/linux-mips64el@npm:0.18.20"
"@esbuild/linux-mips64el@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/linux-mips64el@npm:0.20.1"
conditions: os=linux & cpu=mips64el
languageName: node
linkType: hard

"@esbuild/linux-ppc64@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/linux-ppc64@npm:0.18.20"
"@esbuild/linux-ppc64@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/linux-ppc64@npm:0.20.1"
conditions: os=linux & cpu=ppc64
languageName: node
linkType: hard

"@esbuild/linux-riscv64@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/linux-riscv64@npm:0.18.20"
"@esbuild/linux-riscv64@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/linux-riscv64@npm:0.20.1"
conditions: os=linux & cpu=riscv64
languageName: node
linkType: hard

"@esbuild/linux-s390x@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/linux-s390x@npm:0.18.20"
"@esbuild/linux-s390x@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/linux-s390x@npm:0.20.1"
conditions: os=linux & cpu=s390x
languageName: node
linkType: hard

"@esbuild/linux-x64@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/linux-x64@npm:0.18.20"
"@esbuild/linux-x64@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/linux-x64@npm:0.20.1"
conditions: os=linux & cpu=x64
languageName: node
linkType: hard

"@esbuild/netbsd-x64@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/netbsd-x64@npm:0.18.20"
"@esbuild/netbsd-x64@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/netbsd-x64@npm:0.20.1"
conditions: os=netbsd & cpu=x64
languageName: node
linkType: hard

"@esbuild/openbsd-x64@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/openbsd-x64@npm:0.18.20"
"@esbuild/openbsd-x64@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/openbsd-x64@npm:0.20.1"
conditions: os=openbsd & cpu=x64
languageName: node
linkType: hard

"@esbuild/sunos-x64@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/sunos-x64@npm:0.18.20"
"@esbuild/sunos-x64@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/sunos-x64@npm:0.20.1"
conditions: os=sunos & cpu=x64
languageName: node
linkType: hard

"@esbuild/win32-arm64@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/win32-arm64@npm:0.18.20"
"@esbuild/win32-arm64@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/win32-arm64@npm:0.20.1"
conditions: os=win32 & cpu=arm64
languageName: node
linkType: hard

"@esbuild/win32-ia32@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/win32-ia32@npm:0.18.20"
"@esbuild/win32-ia32@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/win32-ia32@npm:0.20.1"
conditions: os=win32 & cpu=ia32
languageName: node
linkType: hard

"@esbuild/win32-x64@npm:0.18.20":
version: 0.18.20
resolution: "@esbuild/win32-x64@npm:0.18.20"
"@esbuild/win32-x64@npm:0.20.1":
version: 0.20.1
resolution: "@esbuild/win32-x64@npm:0.20.1"
conditions: os=win32 & cpu=x64
languageName: node
linkType: hard
Expand Down Expand Up @@ -5470,7 +5477,7 @@ __metadata:
"@yarnpkg/esbuild-plugin-pnp": "npm:^3.0.0-rc.10"
browser-assert: "npm:^1.2.1"
ejs: "npm:^3.1.8"
esbuild: "npm:^0.18.0"
esbuild: "npm:^0.20.1"
esbuild-plugin-alias: "npm:^0.2.1"
express: "npm:^4.17.3"
fs-extra: "npm:^11.1.0"
Expand Down Expand Up @@ -5737,7 +5744,7 @@ __metadata:
"@yarnpkg/libzip": "npm:2.3.0"
chalk: "npm:^4.1.0"
cross-spawn: "npm:^7.0.3"
esbuild: "npm:^0.18.0"
esbuild: "npm:^0.20.1"
esbuild-register: "npm:^3.5.0"
execa: "npm:^5.0.0"
file-system-cache: "npm:2.3.0"
Expand Down Expand Up @@ -14211,33 +14218,36 @@ __metadata:
languageName: node
linkType: hard

"esbuild@npm:^0.18.0":
version: 0.18.20
resolution: "esbuild@npm:0.18.20"
dependencies:
"@esbuild/android-arm": "npm:0.18.20"
"@esbuild/android-arm64": "npm:0.18.20"
"@esbuild/android-x64": "npm:0.18.20"
"@esbuild/darwin-arm64": "npm:0.18.20"
"@esbuild/darwin-x64": "npm:0.18.20"
"@esbuild/freebsd-arm64": "npm:0.18.20"
"@esbuild/freebsd-x64": "npm:0.18.20"
"@esbuild/linux-arm": "npm:0.18.20"
"@esbuild/linux-arm64": "npm:0.18.20"
"@esbuild/linux-ia32": "npm:0.18.20"
"@esbuild/linux-loong64": "npm:0.18.20"
"@esbuild/linux-mips64el": "npm:0.18.20"
"@esbuild/linux-ppc64": "npm:0.18.20"
"@esbuild/linux-riscv64": "npm:0.18.20"
"@esbuild/linux-s390x": "npm:0.18.20"
"@esbuild/linux-x64": "npm:0.18.20"
"@esbuild/netbsd-x64": "npm:0.18.20"
"@esbuild/openbsd-x64": "npm:0.18.20"
"@esbuild/sunos-x64": "npm:0.18.20"
"@esbuild/win32-arm64": "npm:0.18.20"
"@esbuild/win32-ia32": "npm:0.18.20"
"@esbuild/win32-x64": "npm:0.18.20"
"esbuild@npm:^0.20.1":
version: 0.20.1
resolution: "esbuild@npm:0.20.1"
dependencies:
"@esbuild/aix-ppc64": "npm:0.20.1"
"@esbuild/android-arm": "npm:0.20.1"
"@esbuild/android-arm64": "npm:0.20.1"
"@esbuild/android-x64": "npm:0.20.1"
"@esbuild/darwin-arm64": "npm:0.20.1"
"@esbuild/darwin-x64": "npm:0.20.1"
"@esbuild/freebsd-arm64": "npm:0.20.1"
"@esbuild/freebsd-x64": "npm:0.20.1"
"@esbuild/linux-arm": "npm:0.20.1"
"@esbuild/linux-arm64": "npm:0.20.1"
"@esbuild/linux-ia32": "npm:0.20.1"
"@esbuild/linux-loong64": "npm:0.20.1"
"@esbuild/linux-mips64el": "npm:0.20.1"
"@esbuild/linux-ppc64": "npm:0.20.1"
"@esbuild/linux-riscv64": "npm:0.20.1"
"@esbuild/linux-s390x": "npm:0.20.1"
"@esbuild/linux-x64": "npm:0.20.1"
"@esbuild/netbsd-x64": "npm:0.20.1"
"@esbuild/openbsd-x64": "npm:0.20.1"
"@esbuild/sunos-x64": "npm:0.20.1"
"@esbuild/win32-arm64": "npm:0.20.1"
"@esbuild/win32-ia32": "npm:0.20.1"
"@esbuild/win32-x64": "npm:0.20.1"
dependenciesMeta:
"@esbuild/aix-ppc64":
optional: true
"@esbuild/android-arm":
optional: true
"@esbuild/android-arm64":
Expand Down Expand Up @@ -14284,7 +14294,7 @@ __metadata:
optional: true
bin:
esbuild: bin/esbuild
checksum: 473b1d92842f50a303cf948a11ebd5f69581cd254d599dd9d62f9989858e0533f64e83b723b5e1398a5b488c0f5fd088795b4235f65ecaf4f007d4b79f04bc88
checksum: 7e0303cb80defd55f3f7b85108081afc9c2f3852dda13bf70975a89210f20cd658fc02540d34247401806cb069c4ec489f7cf0df833e040ee361826484926c3a
languageName: node
linkType: hard

Expand Down
2 changes: 1 addition & 1 deletion scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
},
"resolutions": {
"@testing-library/jest-dom": "^5.11.9",
"esbuild": "^0.18.0",
"esbuild": "^0.20.1",
"serialize-javascript": "^3.1.0",
"type-fest": "~2.19"
},
Expand Down