Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic addon decorators #3555

Merged
merged 22 commits into from
May 15, 2018
Merged

Generic addon decorators #3555

merged 22 commits into from
May 15, 2018

Conversation

Hypnosphi
Copy link
Member

Based on decorators for storybook/html

@codecov
Copy link

codecov bot commented May 7, 2018

Codecov Report

Merging #3555 into master will decrease coverage by 0.59%.
The diff coverage is 23.2%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3555     +/-   ##
=========================================
- Coverage   37.08%   36.49%   -0.6%     
=========================================
  Files         511      487     -24     
  Lines       10851    10265    -586     
  Branches      975      944     -31     
=========================================
- Hits         4024     3746    -278     
+ Misses       6227     5941    -286     
+ Partials      600      578     -22
Impacted Files Coverage Δ
lib/core-events/index.js 100% <ø> (ø) ⬆️
addons/knobs/src/components/Panel.js 75.71% <ø> (+2.1%) ⬆️
addons/events/src/components/Panel.js 0% <ø> (ø) ⬆️
lib/channel-postmessage/src/index.js 0% <ø> (ø) ⬆️
addons/viewport/src/preview/index.js 100% <ø> (ø) ⬆️
addons/knobs/src/deprecated.js 0% <0%> (ø)
addons/knobs/src/index.js 0% <0%> (ø) ⬆️
addons/backgrounds/mithril.js 0% <0%> (ø) ⬆️
addons/actions/src/preview/withActions.js 44.7% <0%> (-23.16%) ⬇️
addons/backgrounds/vue.js 0% <0%> (-100%) ⬇️
... and 110 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38992be...da9990e. Read the comment docs.

@@ -1 +1 @@
module.exports = require('./dist/mithril');
module.exports = require('./dist/deprecated');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep those files for one alpha release

@Hypnosphi Hypnosphi changed the title [WIP] Generic addon decorators Generic addon decorators May 12, 2018
@Hypnosphi
Copy link
Member Author

@storybooks/team it's ready for final review

…ators

# Conflicts:
#	addons/viewport/package.json
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wuweiweiwu wuweiweiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addon's are so much cleaner now!

…ators

# Conflicts:
#	ADDONS_SUPPORT.md
#	examples/angular-cli/src/stories/__snapshots__/custom-styles.stories.storyshot
@Hypnosphi Hypnosphi merged commit 47185be into master May 15, 2018
@Hypnosphi Hypnosphi deleted the generic-addon-decorators branch May 15, 2018 22:45
@shilman shilman removed the cleanup Minor cleanup style change that won't show up in release changelog label May 17, 2018
@Hypnosphi
Copy link
Member Author

Released as 4.0.0-alpha.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants