Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and src to npmignore #7824

Merged
merged 62 commits into from
Sep 23, 2019
Merged

Add tests and src to npmignore #7824

merged 62 commits into from
Sep 23, 2019

Conversation

Diokuz
Copy link

@Diokuz Diokuz commented Aug 20, 2019

Hey, guys!

I just added some non-production folders to npmignore.

There are many files, which slow down npm install, docker build and other fs/https-related operations.

I could add more ignores to other packages, if that is okay.

What do you think?

@vercel
Copy link

vercel bot commented Aug 20, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-diokuz-next.storybook.now.sh

@shilman shilman added the maintenance User-facing maintenance tasks label Aug 22, 2019
@ndelangen
Copy link
Member

@Hypnosphi what do you think about this?

@Hypnosphi
Copy link
Member

It's a good idea, but we also need to remove jsnext:main fields:
https://github.com/storybookjs/storybook/search?q=jsnext%3Amain&unscoped_q=jsnext%3Amain

@Hypnosphi
Copy link
Member

I wonder whether a single .npmignore on the root level would work. @shilman can you experiment with it maybe?

@stale
Copy link

stale bot commented Sep 20, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Sep 20, 2019
@ndelangen ndelangen self-assigned this Sep 23, 2019
@stale stale bot removed the inactive label Sep 23, 2019
@ndelangen
Copy link
Member

@Hypnosphi doesn't seem to be an option:
lerna/lerna#296

@ndelangen
Copy link
Member

@Hypnosphi I've removed all .npmignore files, and instead have added an allow-list to all package.json.

@ndelangen ndelangen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 23, 2019
@ndelangen ndelangen added this to the 5.2.x milestone Sep 23, 2019
@ndelangen ndelangen merged commit 87b656e into storybookjs:next Sep 23, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 7, 2019
shilman pushed a commit that referenced this pull request Oct 7, 2019
Add tests and src to npmignore

Co-authored-by: Dmitriy Kuznetsov <d.o.kuznetsov@tinkoff.ru>
Co-authored-by: Norbert de Langen <ndelangen@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants