UI: Fix TooltipLinkList not scrollable #7865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasterra
requested review from
ndelangen,
shilman and
tmeasday
as code owners
|
This pull request is automatically deployed with Now. |
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6150
TooltipLinkList was not scrollable. This was a problem for plugins with many many options. i.e.: a i18n plugin. See screenshots below:
Before:
After:
What I did
I added a maxHeight of 10.5 items (the half is to make it obvious that there are more items if you scroll down), and made overflow-y: auto.
How to test