Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocsPage: show docs.storyDescription above story #8037

Merged
merged 2 commits into from
Sep 10, 2019
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Sep 9, 2019

Issue: N/A

What I did

Show story description above the story on DocsPage based on the docs.storyDescription parameter

How to test

See official-storybook example. I also edited it to show the stories in iframes, just to verify the parameter merging is working properly.

@vercel
Copy link

vercel bot commented Sep 9, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-story-description.storybook.now.sh

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not sure the test of parameter merging really needs to be at that point of the code base, don't we already have a bunch of tests for that feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants