-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-centered: Fix zoom issues for non-Firefox browsers #8442
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/ct4izawat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Will do a sanity check before I merge
@shilman after reading through your comment again, I may have merged before you got a chance to do your sanity check. Please let me know if I should revert and I will do so. |
Issue: #7167
What I did
Fix the issue where zoom functionality mixed with addon centered causes the component to disappear. This fix works for all browsers except Firefox.
@shilman , This was the solution we discussed a while back. If we find a solution that doesn't become impacted by multiple transforms and works for all browsers, this can be replaced at that time.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.