-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs/web-components: Add attributes to props table #8598
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/mti5uur51 |
let's make it fully nice then 💪
/**
* Indicates that the back of the card is shown
*/
this.backSide = false;
@runem be prepared for all the storybook users 💪 and yeah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty awesome guys 😻 - thanks @steel!!
thaankkk you 🤗 |
@daKmoR I created a PR for default value runem/web-component-analyzer#117 |
Issue:
The new web-components framework does not render attributes in the doc block.
What I did
I ran web-component-analyzer to get the most up to date custom-element.json file and added support for
attributes
when extracting props.How to test
Here is what web components kitchen sink app now renders: