Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSF/MDX: Add component id for permalinks #8808

Merged
merged 5 commits into from
Nov 14, 2019
Merged

CSF/MDX: Add component id for permalinks #8808

merged 5 commits into from
Nov 14, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Nov 12, 2019 •
edited
Loading

Issue: #8507

What I did

Add component ID to:

  • CSF loader
  • MDX compiler
  • Codemods
  • Official-storybook (csf / mdx)
  • Documentation (after review) MIGRATION.md

How to test

See included tests, plus official-storybook

@vercel
Copy link

vercel bot commented Nov 12, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/h851d1wrm
🌍 Preview: https://monorepo-git-8507-component-id-for-permalinks.storybook.now.sh

@shilman shilman mentioned this pull request Nov 12, 2019
Merged
4 tasks
@shilman shilman added this to the 5.3.0 milestone Nov 13, 2019
tmeasday
tmeasday approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from previously discussed potential issue with api.stories.selectStory(kind) and any similar APIs we haven't remembered ;)

@shilman shilman merged commit 80abb3f into 8756-deprecate-display-name Nov 14, 2019
@shilman shilman deleted the 8507-component-id-for-permalinks branch November 14, 2019 02:32
@shilman shilman mentioned this pull request Nov 14, 2019
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@aaronmcadam aaronmcadam Awaiting requested review from aaronmcadam

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@ndelangen ndelangen Awaiting requested review from ndelangen

@usulpro usulpro Awaiting requested review from usulpro

Assignees
No one assigned
Labels
core csf feature request mdx
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday