Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add svelte-loader to docs for Svelte guide #8999

Merged
merged 1 commit into from Dec 2, 2019
Merged

Add svelte-loader to docs for Svelte guide #8999

merged 1 commit into from Dec 2, 2019

Conversation

himynameisdave
Copy link
Contributor

Issue: no issue

What I did

I was running Storybook in an open-source Svelte component that I was building with Rollup. Given that I'm not using webpack (but Storybook is), the documentation assumed that svelte-loader was already installed.

I added an additional step to the Svelte guide to install svelte-loader.

How to test

  • Create a component (using this template).
  • Add Storybook, with the manual steps from the Storybook Svelte Guide here.
  • Existing documentation does not indicate that you need svelte-loader, but when you actually run npm run storybook it will fail because it can't find svelte-loader.
  • Add svelte-loader and everything works.

@vercel
Copy link

vercel bot commented Nov 28, 2019 •
edited

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

@himynameisdave himynameisdave changed the title 🏂 Add svelte-loader to docs for Svelte guide Add svelte-loader to docs for Svelte guide Nov 28, 2019
@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Dec 2, 2019
shilman
shilman approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!!

@shilman shilman merged commit f05d91d into storybookjs:next Dec 2, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Dec 2, 2019
shilman added a commit that referenced this pull request Dec 2, 2019
@shilman
Add svelte-loader to docs for Svelte guide (#8999)
a03c730 
Add svelte-loader to docs for Svelte guide
@snyk-bot snyk-bot mentioned this pull request Jan 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees
No one assigned
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@himynameisdave @shilman