Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Q] Any plans to move to @playwright/test? #78

Open
jeremyzilar opened this issue Mar 11, 2022 · 11 comments
Open

[Q] Any plans to move to @playwright/test? #78

jeremyzilar opened this issue Mar 11, 2022 · 11 comments
Labels
question Further information is requested

Comments

@jeremyzilar
Copy link

I noticed that jest-playwright package recommends using @playwright/test over playwright. Any plans to move this this in the future, since it has typescript support out of the box?

@jeremyzilar jeremyzilar added the bug Something isn't working label Mar 11, 2022
@yannbf yannbf added question Further information is requested and removed bug Something isn't working labels Mar 12, 2022
@yannbf
Copy link
Member

yannbf commented Mar 12, 2022

Hey @jeremyzila, we use jest-playwright as the playwright runner does not support file transformations and we need that in order to turn stories into tests. If they ever support that we could totally support it as a runner too.

I wonder what's your use case, specifically the typescript part. Our runner also has support for typescript!

@horacioh
Copy link

what I'm trying to do is to use Vitest instead of Jest to run the test-runner. this will minimize the amount of setup, configs and time to run tests I assume by a substantial amount.

can storybook rely on Vite to transform the stories instead? that would be neat!

@yannbf
Copy link
Member

yannbf commented May 14, 2022

Hey @patak-dev do you think we can already experiment with vite? Will it be able to accept transformations like jest?

@patak-dev
Copy link

Yes, from the code you shown me last time, I dont see any blockers

@yannbf
Copy link
Member

yannbf commented May 14, 2022

Alright, I'll do some experimentations with it! Thanks!

@andykenward
Copy link
Contributor

I think we might be able to use @playwright/test as playwright just appears to be a wrapper to playwright-core. Which is used in @playwright/test aswell.

@andykenward
Copy link
Contributor

It looks like jest-playwright is installing playwright-core too https://github.com/playwright-community/jest-playwright/blob/95b83774be71e3859875ccdcc27e0e5aef28c3ff/package.json#L49.

@andykenward
Copy link
Contributor

It looks like jest-playwright is installing playwright-core too https://github.com/playwright-community/jest-playwright/blob/95b83774be71e3859875ccdcc27e0e5aef28c3ff/package.json#L49.

Ah nope. Still need to install playwright to use jest-playwright-preset. Would've thought that playwright would be a peerDependencies for jest-playwright-preset.

@bryanjtc
Copy link
Member

bryanjtc commented Oct 6, 2022

Any progress on this? @yannbf Did running with vitest instead of jest worked?

@resource11
Copy link

Oooo, I'd love to know this as well, @yannbf. Thanks for all your work on Storybook!

@rc-glean
Copy link

+1, @yannbf. Thank you so much for all your work on storybook!

Just to offer another datapoint, here's (IMO) one compelling reason to support @playwright/test. It has access to the experimental ssim-cie94 image comparator (cross-link microsoft/playwright#13873 (comment)).

Context: a common problem is developers might generate screenshots locally on an arm mac, and execute CI tests against x86 linux.

This yields non-determinism. From https://gitnet.fr/deblan/playwright/commit/6d82460a02dec3393490bcab7b619f668f03e6c6

As of Nov 30, 2022, we identified the following sources of
non-determenistic rendering for Chromium:

  • Anti-aliasing for certain shapes might be different due to the
    way skia rasterizes certain shapes.
  • Color blending might be different on x86 and aarch64
    architectures.

As it stands, non SaaS (chromatic/percy) solutions like Amex's americanexpress/jest-image-snapshot#326 does not have access to this experimental comparator even when setting package.json resolutions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

8 participants