-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Q] Any plans to move to @playwright/test? #78
Comments
Hey @jeremyzila, we use jest-playwright as the playwright runner does not support file transformations and we need that in order to turn stories into tests. If they ever support that we could totally support it as a runner too. I wonder what's your use case, specifically the typescript part. Our runner also has support for typescript! |
what I'm trying to do is to use Vitest instead of Jest to run the test-runner. this will minimize the amount of setup, configs and time to run tests I assume by a substantial amount. can storybook rely on Vite to transform the stories instead? that would be neat! |
Hey @patak-dev do you think we can already experiment with vite? Will it be able to accept transformations like jest? |
Yes, from the code you shown me last time, I dont see any blockers |
Alright, I'll do some experimentations with it! Thanks! |
I think we might be able to use |
It looks like |
Ah nope. Still need to install |
Any progress on this? @yannbf Did running with vitest instead of jest worked? |
Oooo, I'd love to know this as well, @yannbf. Thanks for all your work on Storybook! |
+1, @yannbf. Thank you so much for all your work on storybook! Just to offer another datapoint, here's (IMO) one compelling reason to support Context: a common problem is developers might generate screenshots locally on an arm mac, and execute CI tests against x86 linux. This yields non-determinism. From https://gitnet.fr/deblan/playwright/commit/6d82460a02dec3393490bcab7b619f668f03e6c6
As it stands, non SaaS (chromatic/percy) solutions like Amex's americanexpress/jest-image-snapshot#326 does not have access to this experimental comparator even when setting package.json resolutions |
I noticed that
jest-playwright
package recommends using@playwright/test
overplaywright
. Any plans to move this this in the future, since it has typescript support out of the box?jest-playwright
https://github.com/playwright-community/jest-playwright#configuration@playwright/test
https://playwright.dev/docs/intro#installationThe text was updated successfully, but these errors were encountered: