-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@storybook/core use old babel-loader@7 and he loading babel-core as dependencie #3839
Comments
Please use babel-bringe for now. Storybook 4.0 will have Babel 7 out of the box, you can track the progress in #3746 |
That still won't cut it, I believe: |
How can we use |
Oh, maybe I misunderstood. How can you use |
We (storybook itself) don't (yet), but you (your app) can |
My point was that we can't update babel-loader on our side without migrating to Babel 7 as default, which is being done in #3746 |
If you have yarn, you can use yarn resolutions to enforce v8 though |
Ah, I see what you're saying. We've done that with Is there a way to set the dependencies so that the peer dependencies allow for 7 in the app, but the direct dependency still uses 6 for Storybook's internals? |
If Babel is being used to build Storybook, should the |
This is exactly how it works right now. Or do you mean to make |
No, those are to build user stories |
With and without dependencies
I add postintall script to rm |
If you know best idea to fix this, please notify :) |
@bustEXZ You have solutions
BTW. babel-bridge didn't solved the warning babel/babel#6824 Doing $ yarn check
yarn check v1.7.0
info fsevents@1.2.4: The platform "win32" is incompatible with this module.
info "fsevents@1.2.4" is an optional dependency and failed compatibility check. Excluding it from installation.
error "babel-loader#babel-core@6" doesn't satisfy found match of "babel-core@7.0.0-bridge.0"
... Explanation of babel-bridge:
|
@rofrol 1, 2 allready complete
|
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
@bustEXZ it should be |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
package.json
.babelrc
When we try to start storybook, we have an error:
It solves if we go to
/node_modules/@storybook/core/node_modules/babel-loader/lib/index.js:3:13
and change require from "babel-core" to "@babel/core".The text was updated successfully, but these errors were encountered: