Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: determine whether to add interactive stories from renderer rather than framework #18968

Merged
merged 1 commit into from
Aug 20, 2022
Merged

CLI: determine whether to add interactive stories from renderer rather than framework #18968

merged 1 commit into from
Aug 20, 2022

Conversation

kylegach
Copy link
Contributor

Issue:

What I did

Refactored baseGenerator in the CLI to determine whether a project hasInteractiveStories via the renderer instead of the framework. This helps further delineate the (new) difference between framework and renderer. Pragmatically, this is useful for frameworks like cra (see #18695) and nextjs.

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

@kylegach kylegach added maintenance User-facing maintenance tasks cli labels Aug 19, 2022
@kylegach kylegach self-assigned this Aug 19, 2022
@kylegach kylegach requested a review from yannbf August 19, 2022 15:49
@kylegach kylegach changed the title Determine hasInteractiveStories from rendererId Determine hasInteractiveStories from renderer Aug 19, 2022
@kylegach kylegach mentioned this pull request Aug 19, 2022
Closed
yannbf
yannbf approved these changes Aug 20, 2022
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <3

@yannbf yannbf changed the title Determine hasInteractiveStories from renderer CLI: determine whether to add interactive stories from renderer rather than framework Aug 20, 2022
@yannbf yannbf merged commit aff724a into next Aug 20, 2022
@yannbf yannbf deleted the cli-base-generator-renderer-id branch August 20, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees

@kylegach kylegach

Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylegach @yannbf