Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Bundle lib/channel-postmessage with ts-up #19388

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Build: Bundle lib/channel-postmessage with ts-up #19388

merged 2 commits into from
Oct 13, 2022

Conversation

javier-arango
Copy link
Contributor

Issue: #18732

What I did

Migrated lib/channel-postmessage to use the ts-up bundler.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@socket-security
Copy link

socket-security bot commented Oct 7, 2022

Socket Security Report

👍 No new dependency issues detected in pull request

Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ✅ no new install scripts
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@javier-arango javier-arango added the maintenance User-facing maintenance tasks label Oct 7, 2022
@javier-arango
Copy link
Contributor Author

@IanVS & @ndelangen do you guys know what should I do to pass the smoked-test-sandboxes and the Socket Security checks ?

@IanVS
Copy link
Member

IanVS commented Oct 7, 2022

@javier-arango I think those are issues with the current state of the repo, and not something you've done here.

@javier-arango
Copy link
Contributor Author

@IanVS sounds good, should I put the PR ready for review ?

@IanVS IanVS marked this pull request as ready for review October 7, 2022 19:02
@IanVS IanVS added build Internal-facing build tooling & test updates and removed maintenance User-facing maintenance tasks labels Oct 13, 2022
…message-tsup

# Conflicts:
#	code/lib/channel-postmessage/package.json
@IanVS IanVS changed the title Build lib/channel-postmessage with tsup Build: Bundle lib/channel-postmessage with ts-up Oct 13, 2022
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo hoo, CI is green! Thanks @javier-arango!

@javier-arango
Copy link
Contributor Author

@IanVS Finally we got green CI, I am going to merge the changes now. Thank you for the help.

@javier-arango javier-arango merged commit 349b2e5 into storybookjs:next Oct 13, 2022
@javier-arango javier-arango deleted the feat/lib-channel-postmessage-tsup branch October 13, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants