Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo template gen removal during deprecation property removal #19614

Merged

Conversation

Marklb
Copy link
Member

@Marklb Marklb commented Oct 25, 2022

Issue:

PR #19442 removed the deprecated component property from the StoryFn return, but it also removed the template generation of the story component when template isn't provided in the StoryFn return. Unless I am missing something, the template generation is still needed, unless we expect anything using the renderer to pass in the component and manually call computesTemplateFromComponent to generate a template for the story to use.

What I did

Added component template computation back to the renderer.

How to test

  • Is this testable with Jest or Chromatic screenshots? This is testable, but the Angular tests aren't working in this branch. I noticed the problem while fixing the tests in PR Build: Upgrade Jest to version 28 #19613
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@ndelangen
Copy link
Member

@Marklb could you update this PR by merging in the next branch?

@ndelangen ndelangen requested review from a team and ThibaudAV November 2, 2022 22:05
@ndelangen ndelangen merged commit d99735b into storybookjs:next Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants