e2e: change onClick to click to support svelte examples #20034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
force-pushed
the
fix/addon-actions-e2e-test
branch
from
d175622
to
ec3a465
Compare
yannbf
force-pushed
the
fix/addon-actions-e2e-test
branch
from
ec3a465
to
3b158fc
Compare
JReinhold
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Great!
Matching is case-insensitive and searches for a substring.
https://playwright.dev/docs/selectors#filter-by-text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
In Svelte, the actions panel shows
clickinstead ofonClick. The check now works for both scenariosHow to test
If your answer is yes to any of these, please make sure to include it in your PR.