Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Next 12 sandbox #20092

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Add Next 12 sandbox #20092

merged 3 commits into from
Dec 14, 2022

Conversation

valentinpalkovic
Copy link
Contributor

What I did

Added Next 12 sandbox

How to test

  • Is this testable with Jest or Chromatic screenshots?

@valentinpalkovic valentinpalkovic added the build Internal-facing build tooling & test updates label Dec 5, 2022
@valentinpalkovic valentinpalkovic self-assigned this Dec 5, 2022
@valentinpalkovic valentinpalkovic added the ci:daily Run the CI jobs that normally run in the daily job. label Dec 5, 2022
@valentinpalkovic valentinpalkovic force-pushed the valentin/add-next-12-sandbox branch 2 times, most recently from 256c4f7 to 1038459 Compare December 7, 2022 08:24
yannbf
yannbf approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Don't love the formatting changes in config.yml, they keep going back and forth

@valentinpalkovic
Copy link
Contributor Author

LGTM! Don't love the formatting changes in config.yml, they keep going back and forth

@yannbf Good point. My VSCode has used the internal "YAML" formatter instead of the prettier one to format the file on save. I have changed that behavior. Now the code formatting is configured right for YAML files on save.

@valentinpalkovic valentinpalkovic removed the ci:daily Run the CI jobs that normally run in the daily job. label Dec 14, 2022
@valentinpalkovic valentinpalkovic merged commit 06910f2 into next Dec 14, 2022
@valentinpalkovic valentinpalkovic deleted the valentin/add-next-12-sandbox branch December 14, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

@kylegach kylegach Awaiting requested review from kylegach

Assignees

@valentinpalkovic valentinpalkovic

Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinpalkovic @yannbf