Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS #22869

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Add CODEOWNERS #22869

merged 3 commits into from
Jun 2, 2023

Conversation

vanessayuenn
Copy link
Contributor

@vanessayuenn vanessayuenn commented Jun 1, 2023

What I did

This PR adds a CODEOWNERS file that specifies that all changes in the code and scripts directories will now require approval from @storybookjs/core team. After this PR is merged, I will turn on branch protection rule that makes this a requirement for merging PRs going forward.

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@vanessayuenn vanessayuenn requested a review from a team June 1, 2023 08:39
@vanessayuenn vanessayuenn changed the title Add CODEOWNER Add CODEOWNERS Jun 1, 2023
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to require approval for all critical code paths, but feel free to disagree and merge.

.github/CODEOWNERS Show resolved Hide resolved
vanessayuenn and others added 2 commits June 2, 2023 13:09
Co-authored-by: Jeppe Reinhold <jeppe@chromatic.com>
@vanessayuenn vanessayuenn merged commit 2bd02fe into next Jun 2, 2023
@vanessayuenn vanessayuenn deleted the vy/codeowner branch June 2, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants