Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Horizontal Scrollbar of DownPanel #2410

Merged
merged 5 commits into from
Dec 3, 2017
Merged

Fix Horizontal Scrollbar of DownPanel #2410

merged 5 commits into from
Dec 3, 2017

Conversation

tobilen
Copy link
Contributor

@tobilen tobilen commented Dec 1, 2017

Issue: #2387

What I did

Extend flex property to "1 1 auto", which sets a flex-basis of auto instead of 0%. While this wont work in IE10 or below, those are not supported by storybook anyway :)

How to test

Is this testable with jest or storyshots?
no, since styles with css modules are not snapshot.

Does this need a new example in the kitchen sink apps?
no, there is already one that shows the issue (see link above)

Does this need an update to the documentation?
no

@codecov
Copy link

codecov bot commented Dec 1, 2017

Codecov Report

Merging #2410 into release/3.3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/3.3    #2410   +/-   ##
============================================
  Coverage        18.76%   18.76%           
============================================
  Files              348      348           
  Lines             8200     8200           
  Branches           907      912    +5     
============================================
  Hits              1539     1539           
+ Misses            5986     5959   -27     
- Partials           675      702   +27
Impacted Files Coverage Δ
.../ui/src/modules/ui/components/addon_panel/style.js 0% <ø> (ø) ⬆️
addons/jest/src/components/Indicator.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/index.js 29.28% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
...-native/src/preview/components/OnDeviceUI/index.js 0% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 50% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/search_box.js 35.95% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/search_box.js 23.52% <0%> (ø) ⬆️
addons/knobs/src/components/types/Date/index.js 23.52% <0%> (ø) ⬆️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 295c8b4...6f22aab. Read the comment docs.

@tobilen
Copy link
Contributor Author

tobilen commented Dec 1, 2017

im not really sure how to convince codecov that the coverage didnt change. help? 🐼

Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in FF 57

@Hypnosphi
Copy link
Member

@tobilen would you mind resolving the conflicts?

@tobilen
Copy link
Contributor Author

tobilen commented Dec 3, 2017

@Hypnosphi done

@Hypnosphi Hypnosphi merged commit 5d0770a into storybookjs:release/3.3 Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants