-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Horizontal Scrollbar of DownPanel #2410
Conversation
Codecov Report
@@ Coverage Diff @@
## release/3.3 #2410 +/- ##
============================================
Coverage 18.76% 18.76%
============================================
Files 348 348
Lines 8200 8200
Branches 907 912 +5
============================================
Hits 1539 1539
+ Misses 5986 5959 -27
- Partials 675 702 +27
Continue to review full report at Codecov.
|
im not really sure how to convince codecov that the coverage didnt change. help? 🐼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in FF 57
@tobilen would you mind resolving the conflicts? |
@Hypnosphi done |
Issue: #2387
What I did
Extend flex property to "1 1 auto", which sets a flex-basis of auto instead of 0%. While this wont work in IE10 or below, those are not supported by storybook anyway :)
How to test
Is this testable with jest or storyshots?
no, since styles with css modules are not snapshot.
Does this need a new example in the kitchen sink apps?
no, there is already one that shows the issue (see link above)
Does this need an update to the documentation?
no